Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove step to click 2FA button in the CI #767

Merged
merged 2 commits into from
Apr 19, 2023

Conversation

Darwinkel
Copy link
Contributor

Changes

PR #760 had the subtle side-effect of removing the step that requires a new user to click an additional button. This PR removes that step from the CI as well.

Issue link

Linked directly.

Proof

See CI.


Checklists for authors:

Code Checklist

  • This PR only contains functionality relevant to the issue; tickets have been created for newly discovered issues.
  • I have written unit tests for the changes or fixes I made.
  • For any non-trivial functionality, I have added integration and/or end-to-end tests.
  • I have performed a self-review of my code and refactored it to the best of my abilities.

Communication

  • I have informed others of any required .env changes files if required and changed the .env-dist accordingly.
  • I have made corresponding changes to the documentation, if necessary.

Checklist for code reviewers:

  • The code does not violate Model-View-Template and our other architectural principles.
  • The code prioritizes readability over performance where appropriate.
  • The code does not bypass authentication or security mechanisms.
  • The code does not introduce any dependency on a library that has not been properly vetted.
  • The code contains docstrings, comments, and documentation where needed.

Checklist for QA:

  • I have checked out this branch, and successfully ran a fresh make kat.
  • I confirmed that there are no unintended functional regressions in this branch:
    • I have managed to pass the onboarding flow
    • Objects and Findings are created properly
    • Tasks are created and completed properly
  • I confirmed that the PR's advertised feature or hotfix works as intended.

What works:

  • bullet point + screenshot (if useful) per tested functionality

What doesn't work:

  • bullet point + screenshot (if useful) per tested functionality

Bug or feature?:

  • bullet point + screenshot (if useful) if it is unclear whether something is a bug or an intended feature.

@Darwinkel Darwinkel requested a review from a team as a code owner April 19, 2023 13:15
@Darwinkel Darwinkel changed the title Remove step to click 2FA button Remove step to click 2FA button in the CI Apr 19, 2023
@Darwinkel Darwinkel self-assigned this Apr 19, 2023
@Darwinkel Darwinkel added bug Something isn't working chore labels Apr 19, 2023
@dekkers dekkers merged commit f51e73e into main Apr 19, 2023
@dekkers dekkers deleted the fix/ci-automatic-button-click branch April 19, 2023 13:55
@Darwinkel Darwinkel restored the fix/ci-automatic-button-click branch April 19, 2023 13:57
@Darwinkel Darwinkel deleted the fix/ci-automatic-button-click branch April 19, 2023 13:58
jpbruinsslot added a commit that referenced this pull request Apr 24, 2023
* main:
  Increase PostgreSQL container shm size (#780)
  Move the ID of the button to the parent element (#765)
  Fix key check for encrypted settings (#775)
  1.8 release notes (#773)
  update xtdb issue (#768)
  Remove step to click 2FA button in the CI (#767)
  Bump pytest from 7.2.0 to 7.2.2 (#742)
  Bump djlint from 1.19.16 to 1.19.17 (#743)
  Bump pydantic from 1.10.2 to 1.10.7 (#745)
  Bump robotframework-tidy from 3.4.0 to 4.1.0 (#744)
  Add middleware for requiring authentication (#760)
  Add __repr__ to Task for scheduler (#751)
  Differentiate between TCP and UDP in port bits (#756)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working chore
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants