Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PR template code blocks for easier reviewing #736

Merged
merged 13 commits into from
Apr 25, 2023

Conversation

Darwinkel
Copy link
Contributor

Changes

Trivial: turns the code review and QA checklists into code blocks for easy copy-pasting into comments, as it was before.

@Darwinkel Darwinkel requested a review from a team as a code owner April 14, 2023 13:26
@praseodym
Copy link
Contributor

Maybe we can move them out of the PR template and link to them instead, so that the PR template is shorter and less confusing?

@github-actions
Copy link
Contributor

github-actions bot commented Apr 17, 2023

File Coverage
All files 65%
bits/definitions.py 64%
bits/runner.py 56%
bits/https_availability/https_availability.py 93%
bits/oois_in_headers/oois_in_headers.py 57%
bits/spf_discovery/internetnl_spf_parser.py 55%
bits/spf_discovery/spf_discovery.py 72%
octopoes/api/api.py 89%
octopoes/api/models.py 75%
octopoes/api/router.py 52%
octopoes/core/app.py 69%
octopoes/core/service.py 46%
octopoes/events/events.py 96%
octopoes/events/manager.py 65%
octopoes/models/__init__.py 86%
octopoes/models/datetime.py 66%
octopoes/models/exception.py 83%
octopoes/models/origin.py 70%
octopoes/models/path.py 99%
octopoes/models/types.py 95%
octopoes/models/ooi/certificate.py 96%
octopoes/models/ooi/email_security.py 95%
octopoes/models/ooi/findings.py 94%
octopoes/models/ooi/network.py 97%
octopoes/models/ooi/service.py 91%
octopoes/models/ooi/software.py 71%
octopoes/models/ooi/web.py 81%
octopoes/models/ooi/dns/records.py 95%
octopoes/models/ooi/dns/zone.py 77%
octopoes/repositories/ooi_repository.py 40%
octopoes/repositories/origin_parameter_repository.py 53%
octopoes/repositories/origin_repository.py 53%
octopoes/repositories/scan_profile_repository.py 45%
octopoes/xtdb/client.py 39%
octopoes/xtdb/query_builder.py 69%
octopoes/xtdb/related_field_generator.py 73%
tests/conftest.py 91%

Minimum allowed coverage is 75%

Generated by 🐒 cobertura-action against e6bb4a3

@Darwinkel
Copy link
Contributor Author

Maybe we can move them out of the PR template and link to them instead, so that the PR template is shorter and less confusing?

More like this? https://github.com/minvws/nl-kat-coordination/blob/053796b523e8c883418e881ebc28e52707f747df/.github/pull_request_template.md

@underdarknl underdarknl merged commit 8e9c37f into main Apr 25, 2023
@underdarknl underdarknl deleted the hotfix/pr-template-codeblocks branch April 25, 2023 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants