Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rocky katalogus tests and delete unused fixtures #3884

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dekkers
Copy link
Contributor

@dekkers dekkers commented Nov 25, 2024

Changes

While looking at the coverage of the rocky tests I saw that some lines didn't have coverage:

  • I have removed the unused fixtures
  • I fixed test_valid_plugin_id, the old code only tested if one of the three lines would throw an exception
  • A number of katalogus tests didn't test start with test_ so weren't executed. I've fixed the name and updated the tests, because they never executed they didn't work anymore.

QA notes

Only test code is changed, so no QA needed.


Checklist for code reviewers:

Copy-paste the checklist from the docs/source/templates folder into your comment.


Checklist for QA:

Copy-paste the checklist from the docs/source/templates folder into your comment.

@dekkers dekkers requested a review from a team as a code owner November 25, 2024 21:05
Copy link

sonarcloud bot commented Nov 25, 2024

@dekkers dekkers self-assigned this Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Review
Development

Successfully merging this pull request may close these issues.

1 participant