Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes in Report Overview #3707

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Fixes in Report Overview #3707

wants to merge 6 commits into from

Conversation

madelondohmen
Copy link
Contributor

@madelondohmen madelondohmen commented Oct 21, 2024

Changes

This PR makes the following changes to the Report Overview:

  • Fix the breadcrumbs
  • Change the page description text on the Scheduled Reports page
  • Change the page description text on the Reports History page
  • If scheduled_reports_table or reports_history_table is empty, show an empty state text (instead of an empty table)
  • Remove the "Subreport Name" column in the Scheduled Reports table

Demo

afbeelding
afbeelding
afbeelding

QA notes

  • Go to the Report page.
  • Check the two tabs "History" and "Scheduled". Check the intro text and the empty state text.
  • Create a report without schedule and a scheduled report
  • Check the two tabs again. The table should be visible (no empty state text) and counter should work

Code Checklist

  • All the commits in this PR are properly PGP-signed and verified.
  • This PR only contains functionality relevant to the issue.
  • I have written unit tests for the changes or fixes I made.
  • I have checked the documentation and made changes where necessary.
  • I have performed a self-review of my code and refactored it to the best of my abilities.
  • Tickets have been created for newly discovered issues.
  • For any non-trivial functionality, I have added integration and/or end-to-end tests.
  • I have informed others of any required .env changes files if required and changed the .env-dist accordingly.
  • I have included comments in the code to elaborate on what is not self-evident from the code itself, including references to issues and discussions online, or implicit behavior of an interface.

Checklist for code reviewers:

Copy-paste the checklist from the docs/source/templates folder into your comment.


Checklist for QA:

Copy-paste the checklist from the docs/source/templates folder into your comment.

@madelondohmen madelondohmen self-assigned this Oct 21, 2024
@madelondohmen madelondohmen requested a review from a team as a code owner October 21, 2024 12:16
Copy link

sonarcloud bot commented Oct 21, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
50.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: QA review / functional testing
Development

Successfully merging this pull request may close these issues.

3 participants