-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edit report recipe #3690
base: main
Are you sure you want to change the base?
Edit report recipe #3690
Conversation
…ture/edit-report-recipe
Co-authored-by: ammar92 <[email protected]>
Co-authored-by: ammar92 <[email protected]>
…ters * origin: Add delete schedule functionality for schedules in the scheduler (#3678)
Quality Gate failedFailed conditions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, tiny remarks
@@ -75,6 +75,7 @@ def generate_form_fields(self, hidden_ooi_fields: dict[str, str] | None = None) | |||
or annotation == dict[str, str] | |||
or annotation == list[str] | |||
or annotation == dict[str, JsonValue] | |||
or annotation == dict[str, Any] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding this line makes the conditional checks for dict[str, str]
and dict[str, JsonValue]
redundant. I suggest removing these checks
NOTE: This PR uses the PR #3695
Changes
This PR makes it possible for a user to edit the ReportRecipe.
Issue link
Closes #3687
Demo
Opname.2024-10-16.092638.mp4
QA notes
Code Checklist
.env
changes files if required and changed the.env-dist
accordingly.Checklist for code reviewers:
Copy-paste the checklist from the docs/source/templates folder into your comment.
Checklist for QA:
Copy-paste the checklist from the docs/source/templates folder into your comment.