Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix generate findings report from ooi detail #3369

Merged
merged 5 commits into from
Aug 16, 2024

Conversation

Rieven
Copy link
Contributor

@Rieven Rieven commented Aug 15, 2024

Changes

Change get request to post request when generating a findings report from ooi detail page.

  • OOI is selected from the ooi primary key
  • The report type is findings report

Issue link

#3370

Closes #3370

Code Checklist

  • All the commits in this PR are properly PGP-signed and verified.
  • This PR only contains functionality relevant to the issue.
  • I have written unit tests for the changes or fixes I made.
  • I have checked the documentation and made changes where necessary.
  • I have performed a self-review of my code and refactored it to the best of my abilities.
  • Tickets have been created for newly discovered issues.
  • For any non-trivial functionality, I have added integration and/or end-to-end tests.
  • I have informed others of any required .env changes files if required and changed the .env-dist accordingly.
  • I have included comments in the code to elaborate on what is not self-evident from the code itself, including references to issues and discussions online, or implicit behavior of an interface.

Checklist for code reviewers:

Copy-paste the checklist from the docs/source/templates folder into your comment.


Checklist for QA:

Copy-paste the checklist from the docs/source/templates folder into your comment.

@Rieven Rieven requested a review from a team as a code owner August 15, 2024 09:17
@Rieven Rieven self-assigned this Aug 15, 2024
@stephanie0x00
Copy link
Contributor

Checklist for QA:

  • I have checked out this branch, and successfully ran a fresh make reset.
  • I confirmed that there are no unintended functional regressions in this branch:
    • I have managed to pass the onboarding flow
    • Objects and Findings are created properly
    • Tasks are created and completed properly
  • I confirmed that the PR's advertised feature or hotfix works as intended.
  • I checked the logs for errors and/or warnings and made issues where necessary

What works:

Looks good.

What doesn't work:

n/a

Bug or feature?:

  • The flow currently jumps to the plugins selection of the report flow. This feels a little confusing as I cannot enable any plugins. Are there scenario's where you could actually enable plugins for the findings report? Otherwise I think it is more logical from the user experience view to go directly to the 'naming' page for the report.

A screenshot below to show what it currently looks like:

image

@underdarknl underdarknl merged commit 9e359e9 into main Aug 16, 2024
10 checks passed
@underdarknl underdarknl deleted the fix/findings-report-from-ooi-detail branch August 16, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generate findings report from ooi detail does not work
3 participants