-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support setting a custom JSON schema for copied boefjes #3344
Support setting a custom JSON schema for copied boefjes #3344
Conversation
Signed-off-by: Donny Peeters <[email protected]>
Signed-off-by: Donny Peeters <[email protected]>
Signed-off-by: Donny Peeters <[email protected]>
Signed-off-by: Donny Peeters <[email protected]>
Looks good to me, can be moved to QA if no one else has any code review feedback. |
Checklist for QA:
What works:Unsure yet. What doesn't work:The migration breaks things. There are some SQL errors in the log files, logs are shared with @Donnype Bug or feature?:Unsure yet. |
I haven't been able to find logs of the migration itself, so perhaps that wasn't triggered somehow. We should perhaps rerun the flow and verify the migration was triggered. Also there should indeed be no response body returned from the curl command. TBC! |
Checklist for QA:
What works:I've only tested the QA notes.
What doesn't work:N/A |
Alright ready for merge with some team work 💪 Thanks @madelondohmen ! The rest seems to work as expected. |
Changes
This PR adds a "schema" field to the boefje database models so that we can also change the schema for copied (or new) boefjes. This was still lacking in the current APIs.
Issue link
Closes #3052
Demo
QA notes
Again this is a migration mostly so: check out main, enable dns-records, check out this branch and verify that dns-records is still enabled:
Edit: Verify that the migration ran successfully. The output of the command below should be
5be152459a7b
Code Checklist
Checklist for code reviewers:
Copy-paste the checklist from the docs/source/templates folder into your comment.
Checklist for QA:
Copy-paste the checklist from the docs/source/templates folder into your comment.