Workaround setuptools 72 removing test command #3304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
underdarknl
approved these changes
Jul 29, 2024
jpbruinsslot
added a commit
that referenced
this pull request
Jul 31, 2024
…re/mula/refactor-queue * origin/fix/mula/new_boefjes: Remove unnecessary type hints Record the user who last changed the Scan Profile (#3296) Pre-commit Updates according to code-review Update mula/scheduler/connectors/services/katalogus.py Feat/human readable dates (#3231) Workaround setuptools 72 removing test command (#3304) Remove logging statements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This implements one of the workarounds described in pypa/setuptools#4519
It also fixes that the error was ignored because the shell code didn't use
&&.QA notes
If the CI succeeds it can be merged.
Checklist for code reviewers:
Copy-paste the checklist from the docs/source/templates folder into your comment.
Checklist for QA:
Copy-paste the checklist from the docs/source/templates folder into your comment.