Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give report a name #3258

Merged
merged 275 commits into from
Jul 31, 2024
Merged

Give report a name #3258

merged 275 commits into from
Jul 31, 2024

Conversation

madelondohmen
Copy link
Contributor

@madelondohmen madelondohmen commented Jul 18, 2024

Changes

This PR makes it possible to update, save and show the name of the report.

A user can create a name as follows:

  • A preset name is given (without JS)
  • To edit the name, a user presses the edit button which opens a modal (with JS)
    • The user can edit this name
    • The user can add a reference date to this name, which is based on the current date and time.

This PR includes:

  • Export setup page
  • Table with preset report name and edit-button
  • Modal with:
    • Option to change preset name
    • Reference date options to add to the name
  • Parent report name visible in header of the report instead of "OpenKAT Report"
  • Subreport names visible in the reports
  • Report names visible in the sidemenu
  • First column of report history table now contains the report name instead of the ID
  • First column of the subreport page now contains the report name instead of the ID

This PR does NOT include:

  • Giving a name to the multi report, since multi reports cannot be saved yet

Issue link

Closes #2775
Closes #3183

Demo

Give.report.a.name.mp4

QA notes

  • Check if the onboarding flow still works
  • Check if the report flow works as expected for Generate Report and Aggegrate Report

Code Checklist

  • All the commits in this PR are properly PGP-signed and verified.
  • This PR only contains functionality relevant to the issue.
  • I have written unit tests for the changes or fixes I made.
  • I have checked the documentation and made changes where necessary.
  • I have performed a self-review of my code and refactored it to the best of my abilities.
  • Tickets have been created for newly discovered issues.
  • For any non-trivial functionality, I have added integration and/or end-to-end tests.
  • I have informed others of any required .env changes files if required and changed the .env-dist accordingly.
  • I have included comments in the code to elaborate on what is not self-evident from the code itself, including references to issues and discussions online, or implicit behavior of an interface.

Checklist for code reviewers:

Copy-paste the checklist from the docs/source/templates folder into your comment.


Checklist for QA:

Copy-paste the checklist from the docs/source/templates folder into your comment.

ammar92
ammar92 previously approved these changes Jul 23, 2024
ammar92
ammar92 previously approved these changes Jul 24, 2024
@noamblitz
Copy link
Contributor

While playing around with this branch I found (what I think is) a bug:

When generating a report with one report type and two oois, the suggested name is: "DNS report for mispo.es", while it seems like to suggested name should be: "DNS report for 2 objects".

@noamblitz
Copy link
Contributor

image

I think this should also show the report name

@TwistMeister
Copy link
Contributor

While playing around with this branch I found (what I think is) a bug:

When generating a report with one report type and two oois, the suggested name is: "DNS report for mispo.es", while it seems like to suggested name should be: "DNS report for 2 objects".

@noamblitz Could you provide a screenshot from where you observed this? Because I can't reproduce what you're describing:

Screenshot 2024-07-30 at 16 34 43
Screenshot 2024-07-30 at 16 35 26
Screenshot 2024-07-30 at 16 36 11

@underdarknl underdarknl merged commit eefc519 into main Jul 31, 2024
10 of 11 checks passed
@underdarknl underdarknl deleted the feature/give-subreport-a-name branch July 31, 2024 15:02
jpbruinsslot added a commit that referenced this pull request Aug 6, 2024
* feature/mula/refactor-queue: (70 commits)
  Fix schedule_id when manual rescheduling
  Fix manual rescheduling
  Fix linting
  Pre-commit
  Fix shadowing of python builtin
  Ignore security-sensitive check of random
  Ignore type
  Update from croniter types
  Update croniter
  Fix requirements
  Pre-commit
  Fix for boefje/normalizer runner
  Add code-review suggestions
  Give report a name (#3258)
  Updates according to code review
  Update mula/scheduler/context/context.py
  Update mula/scheduler/context/context.py
  Trying to add stubs
  Fix mypy
  Pre-commit
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Give parent report a name Export setup - give my report a name
10 participants