-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Give report a name #3258
Give report a name #3258
Conversation
# Conflicts: # rocky/reports/templates/generate_report.html # rocky/reports/views/generate_report.py
…est as an example, together with a count query example
…nvws/nl-kat-coordination into feature/give-subreport-a-name
While playing around with this branch I found (what I think is) a bug: When generating a report with one report type and two oois, the suggested name is: "DNS report for mispo.es", while it seems like to suggested name should be: "DNS report for 2 objects". |
@noamblitz Could you provide a screenshot from where you observed this? Because I can't reproduce what you're describing: |
* feature/mula/refactor-queue: (70 commits) Fix schedule_id when manual rescheduling Fix manual rescheduling Fix linting Pre-commit Fix shadowing of python builtin Ignore security-sensitive check of random Ignore type Update from croniter types Update croniter Fix requirements Pre-commit Fix for boefje/normalizer runner Add code-review suggestions Give report a name (#3258) Updates according to code review Update mula/scheduler/context/context.py Update mula/scheduler/context/context.py Trying to add stubs Fix mypy Pre-commit ...
Changes
This PR makes it possible to update, save and show the name of the report.
A user can create a name as follows:
This PR includes:
This PR does NOT include:
Issue link
Closes #2775
Closes #3183
Demo
Give.report.a.name.mp4
QA notes
Code Checklist
.env
changes files if required and changed the.env-dist
accordingly.Checklist for code reviewers:
Copy-paste the checklist from the docs/source/templates folder into your comment.
Checklist for QA:
Copy-paste the checklist from the docs/source/templates folder into your comment.