Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change report flow to POST requests #3174

Merged
merged 29 commits into from
Aug 6, 2024

Conversation

Rieven
Copy link
Contributor

@Rieven Rieven commented Jul 2, 2024

Changes

  • This PR is a part of a larger PR.
  • It implements POST request for OOIs selection (instead of GET)
  • OOI selection will do a post request to report type selection (here you can view which OOIs you've selected)
  • At report type selection page, you can go back to change selection (This is also done with a post request back to the OOI selection page.
  • The other PR part 2 will implement the rest of the flow from report type selection posting to Setup scan/configuration page and saving report for viewing. Other pr: Part 2: Change report flow to POST request for Setup Scan and Saving report #3182

Issue link

#3199

Closes #3199

Demo

QA notes

Will only work for select oois (also works for select all) and next you will go to the report type selection page.
This PR stops there for post request. This is only step 1 which willl havdle only ooi selection and showing report type selection part.


Code Checklist

  • All the commits in this PR are properly PGP-signed and verified.
  • This PR only contains functionality relevant to the issue.
  • I have written unit tests for the changes or fixes I made.
  • I have checked the documentation and made changes where necessary.
  • I have performed a self-review of my code and refactored it to the best of my abilities.
  • Tickets have been created for newly discovered issues.
  • For any non-trivial functionality, I have added integration and/or end-to-end tests.
  • I have informed others of any required .env changes files if required and changed the .env-dist accordingly.
  • I have included comments in the code to elaborate on what is not self-evident from the code itself, including references to issues and discussions online, or implicit behavior of an interface.

Checklist for code reviewers:

Copy-paste the checklist from the docs/source/templates folder into your comment.


Checklist for QA:

Copy-paste the checklist from the docs/source/templates folder into your comment.

rocky/reports/templates/partials/report_ooi_list.html Outdated Show resolved Hide resolved
rocky/reports/views/base.py Outdated Show resolved Hide resolved
rocky/reports/views/base.py Outdated Show resolved Hide resolved
@Rieven Rieven marked this pull request as ready for review July 8, 2024 12:58
@Rieven Rieven requested a review from a team as a code owner July 8, 2024 12:58
@Rieven Rieven self-assigned this Jul 9, 2024
@TwistMeister
Copy link
Contributor

I believe the work done in this particular PR works as intended as I've been able to verify that the mentioned actions are indeed POST requests. What doesn't work is going from the report selection to the next step. That results in an error. After consulting @Rieven I learned that this is indeed intended since that part will be fixed in Part 2 he mentioned above.

So as long as this doesn't get merged without part 2, QA seems all good.

@dekkers dekkers changed the title Step 1: Change report flow to POST request for select OOIs and report type choice Change report flow to POST requests Aug 5, 2024
@underdarknl underdarknl merged commit 4641901 into main Aug 6, 2024
10 checks passed
@underdarknl underdarknl deleted the feat/report-flow-post-request-part-1 branch August 6, 2024 11:48
jpbruinsslot added a commit that referenced this pull request Aug 6, 2024
* main:
  Restructure scheduler development scripts (#3293)
  Change report flow to POST requests (#3174)
jpbruinsslot added a commit that referenced this pull request Aug 8, 2024
* feature/mula/refactor-queue:
  Fix poetry
  Updates according to code review
  Basic audit trails via logging (#3317)
  Raw upload with Scan OOIS (#3169)
  Fix Garbage collection and disappearing ports issue (#3214)
  Formatting
  Formatting
  Fix formatting
  Updated `Django` and `opentelemetry` packages (#3324)
  Restructure scheduler development scripts (#3293)
  Change report flow to POST requests (#3174)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Change report OOI Selection requests to POST requests
4 participants