Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jinja2 and tqdm #2919

Merged
merged 1 commit into from
May 7, 2024
Merged

Update jinja2 and tqdm #2919

merged 1 commit into from
May 7, 2024

Conversation

ammar92
Copy link
Contributor

@ammar92 ammar92 commented May 7, 2024

Changes

This PR updates jinja2 and tqdm

Issue link

Closes #2913
Closes #2914
Closes #2915
Closes #2907


Code Checklist

  • All the commits in this PR are properly PGP-signed and verified.
  • This PR only contains functionality relevant to the issue; tickets have been created for newly discovered issues.
  • I have written unit tests for the changes or fixes I made.
  • For any non-trivial functionality, I have added integration and/or end-to-end tests.
  • I have performed a self-review of my code and refactored it to the best of my abilities.

Communication

  • I have informed others of any required .env changes files if required and changed the .env-dist accordingly.
  • I have made corresponding changes to the documentation, if necessary.
  • I have included comments in the code to elaborate on what is not self-evident from the code itself, including references to issues and discussions online, or implicit behavior of an interface.

Checklist for code reviewers:

Copy-paste the checklist from the docs/source/templates folder into your comment.


Checklist for QA:

Copy-paste the checklist from the docs/source/templates folder into your comment.

@ammar92 ammar92 marked this pull request as ready for review May 7, 2024 12:30
@ammar92 ammar92 requested a review from a team as a code owner May 7, 2024 12:30
@underdarknl underdarknl added the backport Needs to be backported to previous release label May 7, 2024
@underdarknl underdarknl added this to the OpenKAT v1.16 milestone May 7, 2024
@ammar92 ammar92 added the dependencies Pull requests that update a dependency file label May 7, 2024
@stephanie0x00
Copy link
Contributor

Checklist for QA:

  • I have checked out this branch, and successfully ran a fresh make reset.
  • I confirmed that there are no unintended functional regressions in this branch:
    • I have managed to pass the onboarding flow
    • Objects and Findings are created properly
    • Tasks are created and completed properly
  • I confirmed that the PR's advertised feature or hotfix works as intended.

What works:

The updates do not appear to break things.

What doesn't work:

n/a

Bug or feature?:

n/a

@dekkers
Copy link
Contributor

dekkers commented May 7, 2024

We don't use xmlattr jinja2 filter and tqdm is only a dev dependency, so I don't think there is a need to backport this PR.

@dekkers dekkers merged commit 31b1bf3 into main May 7, 2024
19 checks passed
@dekkers dekkers deleted the fix/upgrade-packages branch May 7, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Needs to be backported to previous release dependencies Pull requests that update a dependency file
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants