Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use qualified image URLs in docker-compose #2869

Merged
merged 4 commits into from
Apr 23, 2024
Merged

Conversation

dekkers
Copy link
Contributor

@dekkers dekkers commented Apr 22, 2024

Changes

Use the qualified image URLs in docker-compose. This is necessary because software such as podman don't default to docker hub.


Checklist for code reviewers:

Copy-paste the checklist from the docs/source/templates folder into your comment.


Checklist for QA:

Copy-paste the checklist from the docs/source/templates folder into your comment.

@dekkers dekkers requested a review from a team as a code owner April 22, 2024 09:17
@dekkers dekkers self-assigned this Apr 22, 2024
underdarknl
underdarknl previously approved these changes Apr 22, 2024
@stephanie0x00
Copy link
Contributor

Checklist for QA:

  • I have checked out this branch, and successfully ran a fresh make reset.
  • I confirmed that there are no unintended functional regressions in this branch:
    • I have managed to pass the onboarding flow
    • Objects and Findings are created properly
    • Tasks are created and completed properly
  • I confirmed that the PR's advertised feature or hotfix works as intended.

What works:

Looks good, performed some scans, created a report, onboarding works, tasks and findings are created.

What doesn't work:

Haven't found anything out of the ordinary.

Bug or feature?:

Haven't found anything out of the ordinary.

@ammar92
Copy link
Contributor

ammar92 commented Apr 23, 2024

Looks good to me. For some reason it's not able to fetch wiremock:2.34.0 anymore, even though it does exist on Docker Hub. It might be a backend problem on their side. I suggest to take a look at a newer image version, since the current version is quite old already.

ammar in ~ ❯ docker search docker.io/library/wiremock/wiremock:2.34.0
NAME      DESCRIPTION   STARS     OFFICIAL

ammar in ~ ❯ docker search docker.io/library/wiremock/wiremock
NAME                DESCRIPTION                                     STARS     OFFICIAL
wiremock/wiremock   Official images for the WireMock standalone …   27

ammar in ~ ❯ docker search library/wiremock/wiremock
NAME                DESCRIPTION                                     STARS     OFFICIAL
wiremock/wiremock   Official images for the WireMock standalone …   27

ammar in ~ ❯ docker search library/wiremock/wiremock:2.34.0
NAME      DESCRIPTION   STARS     OFFICIAL

ammar in ~ ❯ docker search wiremock/wiremock:2.34.0
NAME      DESCRIPTION   STARS     OFFICIAL

@ammar92
Copy link
Contributor

ammar92 commented Apr 23, 2024

Looks good to me. For some reason it's not able to fetch wiremock:2.34.0 anymore, even though it does exist on Docker Hub. It might be a backend problem on their side. I suggest to take a look at a newer image version, since the current version is quite old already.

Discussed this offline with @dekkers. Seems to be a mismatch in the image reference. I've just updated it and it should be ready for merge now.

@underdarknl underdarknl merged commit cf73592 into main Apr 23, 2024
31 checks passed
@underdarknl underdarknl deleted the compose-qualified-names branch April 23, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants