Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated idna package #2845

Merged
merged 1 commit into from
Apr 12, 2024
Merged

Updated idna package #2845

merged 1 commit into from
Apr 12, 2024

Conversation

ammar92
Copy link
Contributor

@ammar92 ammar92 commented Apr 12, 2024

Changes

Updates idna package

Issue link

Closes #2837
Closes #2838
Closes #2839
Closes #2840
Closes #2841
Closes #2842
Closes #2843
Closes #2844


Code Checklist

  • All the commits in this PR are properly PGP-signed and verified.
  • This PR only contains functionality relevant to the issue; tickets have been created for newly discovered issues.
  • I have written unit tests for the changes or fixes I made.
  • For any non-trivial functionality, I have added integration and/or end-to-end tests.
  • I have performed a self-review of my code and refactored it to the best of my abilities.

Communication

  • I have informed others of any required .env changes files if required and changed the .env-dist accordingly.
  • I have made corresponding changes to the documentation, if necessary.
  • I have included comments in the code to elaborate on what is not self-evident from the code itself, including references to issues and discussions online, or implicit behavior of an interface.

Checklist for code reviewers:

Copy-paste the checklist from the docs/source/templates folder into your comment.


Checklist for QA:

Copy-paste the checklist from the docs/source/templates folder into your comment.

@ammar92 ammar92 added the dependencies Pull requests that update a dependency file label Apr 12, 2024
@ammar92 ammar92 marked this pull request as ready for review April 12, 2024 08:55
@ammar92 ammar92 requested a review from a team as a code owner April 12, 2024 08:55
@underdarknl underdarknl merged commit d7c4fef into main Apr 12, 2024
41 checks passed
@underdarknl underdarknl deleted the fix/update-idna branch April 12, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants