Docs update on OCI image building from current Python/Docker boefjes #2827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename technical_design to installation_and_deployment because that's the title and contents Signed-off-by: Donny Peeters <[email protected]>
Donnype
changed the title
…are presenting our considerations in these sections.
ammar92
reviewed
Apr 24, 2024
Signed-off-by: Donny Peeters <[email protected]>
ammar92
previously approved these changes
Apr 30, 2024
|
No QA comments. Looks good for now. |
…design # Conflicts: # docs/source/developer_documentation/boefjes-runner.md
underdarknl
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename technical_design to installation_and_deployment because that's the title and contents.
Add considerations on image building.
Changes
Documentation update including one url change. Not sure if there are external sources pointing to the url though. But I do think this is a better name as I keep getting confused looking for the place I need to add docs.
Issue link
Closes #2756
Demo
Code Checklist
Communication
.envchanges files if required and changed the.env-distaccordingly.Checklist for code reviewers:
Copy-paste the checklist from the docs/source/templates folder into your comment.
Checklist for QA:
Copy-paste the checklist from the docs/source/templates folder into your comment.