Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change titles to meet configuration page design #2818

Merged
merged 6 commits into from
Apr 12, 2024

Conversation

madelondohmen
Copy link
Contributor

@madelondohmen madelondohmen commented Apr 10, 2024

Changes

This PR makes small changes to the texts/titles in the report flow, to meet the design.
The current plugin "Setup" page will now serve as a "Configuration" page.

Issue link

Closes #2817

Demo

afbeelding

Extra information

For now, it really only turned out to be a matter of adjusting a few titles, nothing more.

There are still a few things that are in the design, but not included in the PR right now, namely:

  • The stepper that Heleen made in Build new stepper component #2394
  • The Overview/Extra information tab
  • The Generate Report/Aggregate Report/Multi Report tab is still in there

I didn't include these in this PR, because:

  • The first one is grayed out in the design.
  • That second one is useless/confusing because there is no "Extra information" page yet. Plus also grayed out in the design.
  • The third one is still needed in the current report flow.

Code Checklist

  • All the commits in this PR are properly PGP-signed and verified.
  • This PR only contains functionality relevant to the issue; tickets have been created for newly discovered issues.
  • I have written unit tests for the changes or fixes I made.
  • For any non-trivial functionality, I have added integration and/or end-to-end tests.
  • I have performed a self-review of my code and refactored it to the best of my abilities.

Communication

  • I have informed others of any required .env changes files if required and changed the .env-dist accordingly.
  • I have made corresponding changes to the documentation, if necessary.
  • I have included comments in the code to elaborate on what is not self-evident from the code itself, including references to issues and discussions online, or implicit behavior of an interface.

Checklist for code reviewers:

Copy-paste the checklist from the docs/source/templates folder into your comment.


Checklist for QA:

Copy-paste the checklist from the docs/source/templates folder into your comment.

@madelondohmen madelondohmen self-assigned this Apr 10, 2024
@madelondohmen madelondohmen requested a review from a team as a code owner April 10, 2024 16:21
ammar92
ammar92 previously approved these changes Apr 11, 2024
@stephanie0x00
Copy link
Contributor

Checklist for QA:

  • I have checked out this branch, and successfully ran a fresh make reset.
  • I confirmed that there are no unintended functional regressions in this branch:
    • I have managed to pass the onboarding flow
    • Objects and Findings are created properly
    • Tasks are created and completed properly
  • I confirmed that the PR's advertised feature or hotfix works as intended.

What works:

Looks good.

What doesn't work:

n/a

Bug or feature?:

n/a

@underdarknl underdarknl merged commit 725fdde into main Apr 12, 2024
10 checks passed
@underdarknl underdarknl deleted the feature/create-report-config-page branch April 12, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setup config page for new report flow
4 participants