Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't show records of the nameservers of chosen hostnames in DNS report #2809

Merged
merged 2 commits into from
Apr 24, 2024

Conversation

noamblitz
Copy link
Contributor

Changes

Previously we showed the records of the nameservers in the records table, now we separate the query so only the records of the chosen hostname are shown.

Demo

Please add some proof in the form of screenshots or screen recordings to show (off) new functionality, if there are interesting new features for end-users.


Code Checklist

  • All the commits in this PR are properly PGP-signed and verified.
  • This PR only contains functionality relevant to the issue; tickets have been created for newly discovered issues.
  • I have written unit tests for the changes or fixes I made.
  • For any non-trivial functionality, I have added integration and/or end-to-end tests.
  • I have performed a self-review of my code and refactored it to the best of my abilities.

Communication

  • I have informed others of any required .env changes files if required and changed the .env-dist accordingly.
  • I have made corresponding changes to the documentation, if necessary.
  • I have included comments in the code to elaborate on what is not self-evident from the code itself, including references to issues and discussions online, or implicit behavior of an interface.

Checklist for code reviewers:

Copy-paste the checklist from the docs/source/templates folder into your comment.


Checklist for QA:

Copy-paste the checklist from the docs/source/templates folder into your comment.

@noamblitz noamblitz requested a review from a team as a code owner April 9, 2024 11:02
@dekkers dekkers changed the title Don;t show records of nameservers Don't show records of the nameservers of chosen hostnames in DNS report Apr 9, 2024
@underdarknl
Copy link
Contributor

Im thinking this query does not return sub-zones anymore?

@noamblitz
Copy link
Contributor Author

Indeed, it does not show the records of the subzones, only of the chosen hostname

@underdarknl
Copy link
Contributor

I would expect a DNS report to carry information on the chosen DNS-zone and its subdomains, or for the dns-zone and its subzones if a hostname was selected:

DNS report for hostname: www.minvws.nl

  • Parent DNS-Zone minvws.nl (and its nameservers)
  • sibling records: www/staging/mail
  • Child Zones for parent Zone:
    ** acc.minvws.nl
    ** dev.minvws.nl

DNS report for DNS-Zone minvws.nl

  • DNS-Zone minvws.nl (and its nameservers)
  • Records: www/staging/mail
  • Child Zones:
    ** acc.minvws.nl
    ** dev.minvws.nl

If we need to include the parent DNS-Zone for each if that zone is a tld is up for disussion I'd say.
If we need to include the child-records for child-zones is also up for disussion I'd say.
Lets validate this with our users.

@stephanie0x00
Copy link
Contributor

stephanie0x00 commented Apr 23, 2024

Checklist for QA:

  • I have checked out this branch, and successfully ran a fresh make reset.
  • I confirmed that there are no unintended functional regressions in this branch:
    • I have managed to pass the onboarding flow
    • Objects and Findings are created properly
    • Tasks are created and completed properly
  • I confirmed that the PR's advertised feature or hotfix works as intended.

What works:

It seems to look good, only records for the domain are now shown, instead of also the records of the name servers.

image

What doesn't work:

nothing found.

Bug or feature?:

nothing found.

@underdarknl underdarknl merged commit 0a4b93f into main Apr 24, 2024
10 checks passed
@underdarknl underdarknl deleted the fix/dns-report-records branch April 24, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants