fix schema errors on empty / missing schemas #2744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ammar92
previously approved these changes
Mar 29, 2024
|
More fixes for the other issues. |
ammar92
approved these changes
Apr 2, 2024
There was a problem hiding this comment.
Looks good to me. I've manually run these commands to compile a list of consumes and produces and confirmed that there are no remaining issues anymore:
find . -name 'boefje.json' | xargs -n 1 jq '.consumes | .[]'
find . -name 'normalizer.json' | xargs -n 1 jq '.consumes | .[]'
find . -name 'normalizer.json' | xargs -n 1 jq '.produces | .[]'
Checklist for QA:
What works:Looks good, enabled all boefjes that do not require some user configuration (eg. API key), ran the boefjes against mispo.es and not seeing the 'invalid schema' errors in the rocky logs anymore or new issues appear. What doesn't work:n/a Bug or feature?:n/a |
dekkers
approved these changes
Apr 3, 2024
jpbruinsslot
added a commit
that referenced
this pull request
Apr 4, 2024
* main: (51 commits) Fix static files for container images/Debian packages when DEBUG is on (#2742) OOI selection at Aggregate report does not remember changed selection (#2619) fix schema errors on empty / missing schemas (#2744) Updated `phonenumbers` and `django-phonenumber-field` (#2757) Remove octopoes coverage workflow (#2755) Bump actions/configure-pages from 4 to 5 (#2745) Add xtdb-cli tool to Octopoes (#2733) Dont report vulnerabilities without version info of the software for snyk (#2730) Feature/boefjes to oci images (#2709) Query non-reference fields and subclass-specific fields through path queries (#2662) Fix in System Specific (#2732) Plugins overview in appendix not showing any plugins (#2694) Feat stepper design v2 (#2704) Undo project-directory in Rocky (#2734) Remove Docker Compose: "version" (#2718) Upgrade `pre-commit` hooks (#2729) Fix #1739 (#2705) Improve generate report (#2633) Fix critical vulnerability counter (#2712) Fix pdf alignment (#2674) ...
dekkers
added a commit
that referenced
this pull request
Apr 15, 2024
Co-authored-by: ammar92 <[email protected]> Co-authored-by: Jeroen Dekkers <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Dont error on missing optional plugin schemas anymore
Issue link
Closes #2740
Code Checklist
Communication
.envchanges files if required and changed the.env-distaccordingly.Checklist for code reviewers:
Copy-paste the checklist from the docs/source/templates folder into your comment.
Checklist for QA:
Copy-paste the checklist from the docs/source/templates folder into your comment.