-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/disallowed domains in csp #2624
Conversation
octopoes/bits/disallowed_csp_hostnames/disallowed_csp_hostnames.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Jan Klopper <[email protected]>
…s.py Co-authored-by: Jan Klopper <[email protected]>
Co-authored-by: Jan Klopper <[email protected]>
Unfortunately, something goes wrong in rocky which causes an error on submitting the form with booleans instead of strings |
octopoes/bits/disallowed_csp_hostnames/disallowed_csp_hostnames.py
Outdated
Show resolved
Hide resolved
…s.py Co-authored-by: ammar92 <[email protected]>
…m/minvws/nl-kat-coordination into feature/disallowed-domains-in-csp
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one, almost there! If you implement te test like this (pseudocode):
assert results = [ KATFindingType, Finding ]
This way you also verify the length and order for free 👍
# Conflicts: # octopoes/poetry.lock # octopoes/pyproject.toml # octopoes/requirements-dev.txt # octopoes/requirements.txt
I fixed the merge conflict, should be testable now |
Checklist for QA:
What works:
What doesn't work:n/a Bug or feature?:
|
I would expect the report to say 'CSP header present 1/1` but then not list the CSP as secure in the following line so '0/1'. |
Lets create a ticket to add this to the report. Since it was not part of the original ticket i think its not a good idea to let this PR hang on it. |
Changes
Add bit that checks for disallowed domains in csp header
Add bit that asks the relevant question
Issue link
Closes #2571
TO DO: unit test
Code Checklist
Communication
.env
changes files if required and changed the.env-dist
accordingly.Checklist for code reviewers:
Copy-paste the checklist from the docs/source/templates folder into your comment.
Checklist for QA:
Copy-paste the checklist from the docs/source/templates folder into your comment.