Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix architecture check for Wappalyzer boefje #2620

Merged
merged 2 commits into from
Mar 7, 2024
Merged

Fix architecture check for Wappalyzer boefje #2620

merged 2 commits into from
Mar 7, 2024

Conversation

noamblitz
Copy link
Contributor

Changes

Fixed the check which architecture you use for the Wappalyzer check.

@noamblitz noamblitz requested a review from a team as a code owner March 7, 2024 11:46
Donnype
Donnype approved these changes Mar 7, 2024
View reviewed changes
Copy link
Contributor

@Donnype Donnype left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PC (with & without container):
x86_64

Macbook pro M2:
arm64

Macbook pro M2 in container:
aarch64

So seems to work!

@madelondohmen
Copy link
Contributor

Seems to work on Windows 11 with WSL2. Output is "x86_64".

@dekkers dekkers merged commit c0a773e into main Mar 7, 2024
8 of 9 checks passed
@dekkers dekkers deleted the fix/wappalyzer-arch-check branch March 7, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Donnype Donnype Donnype approved these changes

@dekkers dekkers dekkers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@noamblitz @madelondohmen @dekkers @Donnype