Safe Connections Report unit tests

[madelondohmen]

Changes

This PR creates unit tests for Safe Connections Report.

It also makes some changes in the report itself:

• One of the returns "finding_types" was unnecessary and never used, so this part is deleted.

Issue link

Closes #2479

---

Code Checklist

• All the commits in this PR are properly PGP-signed and verified.
• This PR only contains functionality relevant to the issue; tickets have been created for newly discovered issues.
• I have written unit tests for the changes or fixes I made.
• For any non-trivial functionality, I have added integration and/or end-to-end tests.
• I have performed a self-review of my code and refactored it to the best of my abilities.

Communication

• I have informed others of any required .env changes files if required and changed the .env-dist accordingly.
• I have made corresponding changes to the documentation, if necessary.
• I have included comments in the code to elaborate on what is not self-evident from the code itself, including references to issues and discussions online, or implicit behavior of an interface.

---

Checklist for code reviewers:

Copy-paste the checklist from the docs/source/templates folder into your comment.

---

Checklist for QA:

Copy-paste the checklist from the docs/source/templates folder into your comment.

[ammar92]

It looks good in general, but the tests can be improved. It tests the size of the expected output, but apart from that it doesn't really validate the expected output. A good test would validate the output size, (some) content (and order if it matters).

For example, in test_safe_connections_report_multiple_finding_types you could verify if the report indeed contains one of the OOI fixtures.

[ammar92]

No more remarks