Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove duplicate oois from report #2504

Merged
merged 2 commits into from
Feb 14, 2024
Merged

Conversation

noamblitz
Copy link
Contributor

@noamblitz noamblitz commented Feb 14, 2024

Changes

Removes duplicate oois from report from report requests like:

http://localhost:8000/en/as/reports/generate-report/view/?observed_at=2024-02-14&ooi=Hostname%7Cinternet%7Cmispo.es&ooi=Hostname%7Cinternet%7Cmispo.es&clearance_level=2&clearance_level=3&clearance_level=4&clearance_type=declared&plugin=nmap&plugin=dns-records&report_type=systems-report

Issue link

Closes #2503


Code Checklist

  • All the commits in this PR are properly PGP-signed and verified.
  • This PR only contains functionality relevant to the issue; tickets have been created for newly discovered issues.
  • I have written unit tests for the changes or fixes I made.
  • For any non-trivial functionality, I have added integration and/or end-to-end tests.
  • I have performed a self-review of my code and refactored it to the best of my abilities.

Communication

  • I have informed others of any required .env changes files if required and changed the .env-dist accordingly.
  • I have made corresponding changes to the documentation, if necessary.
  • I have included comments in the code to elaborate on what is not self-evident from the code itself, including references to issues and discussions online, or implicit behavior of an interface.

Checklist for code reviewers:

Copy-paste the checklist from the docs/source/templates folder into your comment.


Checklist for QA:

Copy-paste the checklist from the docs/source/templates folder into your comment.

@noamblitz noamblitz requested a review from a team as a code owner February 14, 2024 10:50
@underdarknl underdarknl merged commit c056e85 into main Feb 14, 2024
10 checks passed
@underdarknl underdarknl deleted the fix/duplicate-oois-report branch February 14, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong count of objects in report flow
2 participants