Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update typing to Python 3.10 style #2491

Merged
merged 4 commits into from
Feb 16, 2024
Merged

Update typing to Python 3.10 style #2491

merged 4 commits into from
Feb 16, 2024

Conversation

dekkers
Copy link
Contributor

@dekkers dekkers commented Feb 12, 2024

Changes

This updates typing to the new Python 3.10 style. It also enables the ruff rules that check for this.

Almost all of the changes in this PR have been made by ruff. There were few places that ruff gave an error and couldn't fix it that I had to do by hand.

This only changes typing to things that are syntatically different but the same thing, so it shouldn't have any impact. It might still be good to do QA to make sure everything work correctly, especially because pydantic and FastAPI also do runtime things with types.


Checklist for code reviewers:

Copy-paste the checklist from the docs/source/templates folder into your comment.


Checklist for QA:

Copy-paste the checklist from the docs/source/templates folder into your comment.

@dekkers dekkers requested a review from a team as a code owner February 12, 2024 15:38
@dekkers dekkers self-assigned this Feb 12, 2024
@dekkers dekkers marked this pull request as draft February 12, 2024 15:42
@dekkers dekkers marked this pull request as ready for review February 14, 2024 14:07
@ammar92
Copy link
Contributor

ammar92 commented Feb 16, 2024

Checklist for QA:

  • I have checked out this branch, and successfully ran a fresh make reset.
  • I confirmed that there are no unintended functional regressions in this branch:
    • I have managed to pass the onboarding flow
    • Objects and Findings are created properly
    • Tasks are created and completed properly
  • I confirmed that the PR's advertised feature or hotfix works as intended.

What works:

Seems to work as usual.

@underdarknl underdarknl merged commit f8fc646 into main Feb 16, 2024
39 checks passed
@underdarknl underdarknl deleted the update-typing-to-310 branch February 16, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants