Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Starlette, FastAPI and Django #2480

Merged
merged 2 commits into from
Feb 9, 2024

Conversation

dekkers
Copy link
Contributor

@dekkers dekkers commented Feb 8, 2024

Changes

Fixes security issues in Starlette and Django. FastAPI is also updated to the next minor version because Starlette can't be updated without updating FastAPI.


Checklist for code reviewers:

Copy-paste the checklist from the docs/source/templates folder into your comment.


Checklist for QA:

Copy-paste the checklist from the docs/source/templates folder into your comment.

@dekkers dekkers requested a review from a team as a code owner February 8, 2024 13:43
@underdarknl underdarknl merged commit 9ae8fd4 into main Feb 9, 2024
51 checks passed
@underdarknl underdarknl deleted the update-starlette-fastapi-django branch February 9, 2024 09:41
@underdarknl
Copy link
Contributor

underdarknl commented Feb 12, 2024

Checklist for QA:

  • I have checked out this branch, and successfully ran a fresh make reset.
  • I confirmed that there are no unintended functional regressions in this branch:
    • I have managed to pass the onboarding flow
    • Objects and Findings are created properly
    • Tasks are created and completed properly
  • I confirmed that the PR's advertised feature or hotfix works as intended.

What works:

Everything seems to work, from onboarding to reports, tasklists etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants