Add unit tests for vulnerability report and fix first_seen #2462
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This adds unit tests for the vulnerability report. I spend some time figuring out how to best mock the octopoes calls. I created a a mock octopoes connector class on which you can set a dictionary with queries and the results that should be returned. Suggestions on how to this better / make it easier to write tests are welcome.
It also fixes that first_seen of the previous finding was used if the finding didn't have a history (I spotted this while reading the code to write the tests).
Checklist for code reviewers:
Copy-paste the checklist from the docs/source/templates folder into your comment.
Checklist for QA:
Copy-paste the checklist from the docs/source/templates folder into your comment.