Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mypy and application bootstrap test to boefjes #2460

Merged
merged 4 commits into from
Feb 8, 2024

Conversation

Donnype
Copy link
Contributor

@Donnype Donnype commented Feb 7, 2024

Changes

I think #2454 and #2458 speak for themselves. With the changes in this PR, this would have never happened in the first place and therefore prevents the same issue in the future.

Demo

image


Code Checklist

  • All the commits in this PR are properly PGP-signed and verified.
  • This PR only contains functionality relevant to the issue; tickets have been created for newly discovered issues.
  • I have written unit tests for the changes or fixes I made.
  • For any non-trivial functionality, I have added integration and/or end-to-end tests.
  • I have performed a self-review of my code and refactored it to the best of my abilities.

Communication

  • I have informed others of any required .env changes files if required and changed the .env-dist accordingly.
  • I have made corresponding changes to the documentation, if necessary.
  • I have included comments in the code to elaborate on what is not self-evident from the code itself, including references to issues and discussions online, or implicit behavior of an interface.

Checklist for code reviewers:

Copy-paste the checklist from the docs/source/templates folder into your comment.


Checklist for QA:

Copy-paste the checklist from the docs/source/templates folder into your comment.

@Donnype Donnype requested a review from a team as a code owner February 7, 2024 13:18
# Conflicts:
#	boefjes/boefjes/app.py
#	boefjes/boefjes/job_handler.py
@stephanie0x00
Copy link
Contributor

Checklist for QA:

  • I have checked out this branch, and successfully ran a fresh make reset.
  • I confirmed that there are no unintended functional regressions in this branch:
    • I have managed to pass the onboarding flow
    • Objects and Findings are created properly
    • Tasks are created and completed properly
  • I confirmed that the PR's advertised feature or hotfix works as intended.

What works:

Seems to all work. Can confirm that #2454 and #2458 are resolved too. Everything builds nicely, objects are created as expected, task run, can enable additional boefjes, findings and reports are created.

What doesn't work:

n/a

Bug or feature?:

n/a

@dekkers dekkers merged commit cbd5f1c into main Feb 8, 2024
11 checks passed
@dekkers dekkers deleted the fix/mypy-for-boefjes branch February 8, 2024 10:39
jpbruinsslot added a commit that referenced this pull request Feb 8, 2024
* main:
  Select all OOIS for Aggregate Reports (#2222)
  Add timeouts to CVE API downloader (#2455)
  Fix/normalizer produces, list was empty. is now populated and links to object page (#2411)
  Add mypy and application bootstrap test to boefjes (#2460)
  Add traces for pop and push to queue in scheduler (#2467)
  Feature/report benchmarks (#2447)
  Hotfix for default arg (#2458)
  Fix argument order and hence avoid the octopoes factory (#2454)
  upgrade forcediphttpsadapter (#2453)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants