Remove icons from compliance issue table #2340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ammar92
reviewed
Jan 16, 2024
underdarknl
approved these changes
Jan 17, 2024
jpbruinsslot
added a commit
that referenced
this pull request
Jan 18, 2024
* main: (21 commits) Add IPv6 config to docker-compose.yml (#2256) Remove IPs with zero vulnerabilities (#2319) Translations update from Hosted Weblate (#2311) Chore/update pr template with comments (#2305) Sector report summary - Best and worst scoring security checks (#2312) Remove icons from compliance issue table (#2340) More ulimits for buggy celery (#2338) Remove smartphone from bug report template (#2334) add meta / cache hash for rpki boefje to raw output (#2255) Add max fds ulimit to octopoes api worker (#2327) Fix multiple Debian issues (#2283) Fix/upgrade jinja2 (#2326) Remove preselection from multireport flow (#2318) Updated template file to respect environment prefixes in docs (#2317) fix zero division (#2298) List item behaviour (#2281) Translations update from Hosted Weblate (#2279) Fixed invalid type usage in `get_rabbit_channel` and `close_rabbit_channel` (#2280) Translations update from Hosted Weblate (#2261) Fix export buttons report (#2259) ...
dekkers
pushed a commit
that referenced
this pull request
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Icons from compliance issue table (before the description) have been removed in agreement with the UX designers.
It was redundent for the report.
Demo
Code Checklist
Communication
.envchanges files if required and changed the.env-distaccordingly.Checklist for code reviewers:
Copy-paste the checklist from the docs/source/templates folder into your comment.
Checklist for QA:
Copy-paste the checklist from the docs/source/templates folder into your comment.