Fix rstcheck hook
#1584
Merged
Fix rstcheck hook
#1584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ammar <[email protected]>
dekkers
approved these changes
Aug 9, 2023
jpbruinsslot
pushed a commit
that referenced
this pull request
Aug 14, 2023
jpbruinsslot
added a commit
that referenced
this pull request
Aug 14, 2023
* main: Add sectxt dependency (#1610) Refactor environment settings, names, and documentation (#1517) Add pipeline to check if there are new translation strings (#1606) Translations update from Hosted Weblate (#1604) Update scheduler documentation (#1476) Add community install/update scripts (#1309) Bump actions/checkout from 1 to 3 (#1598) Run docker-compose pull in make pull (#1585) Configure github actions in dependabot (#1594) fix many ports open normalizer (#1592) Fix human-readable name for ImageMetadata (#1558) Upgrade FastAPI (#1576) OOI Detail page: Remember page position after clicking the "show inheritance" link (#1590) Fix `rstcheck` hook (#1584)
jpbruinsslot
added a commit
that referenced
this pull request
Aug 15, 2023
* main: Fix env setting issues found in test debian workflow (#1608) Add sectxt dependency (#1610) Refactor environment settings, names, and documentation (#1517) Add pipeline to check if there are new translation strings (#1606) Translations update from Hosted Weblate (#1604) Update scheduler documentation (#1476) Add community install/update scripts (#1309) Bump actions/checkout from 1 to 3 (#1598) Run docker-compose pull in make pull (#1585) Configure github actions in dependabot (#1594) fix many ports open normalizer (#1592) Fix human-readable name for ImageMetadata (#1558) Upgrade FastAPI (#1576) OOI Detail page: Remember page position after clicking the "show inheritance" link (#1590) Fix `rstcheck` hook (#1584) Manage boefjes requirements with Poetry (#1572)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This fix ignores the
mermaiddirective by therstcheckhook since it doesn't support this directive (yet). We should still find another way to properly check/ lint the Mermaid diagrams we create.Code Checklist
Communication
.envchanges files if required and changed the.env-distaccordingly.Checklist for code reviewers:
Copy-paste the checklist from the docs/source/templates folder into your comment.
Checklist for QA:
Copy-paste the checklist from the docs/source/templates folder into your comment.