-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redteamer can now acknowledge clearance level during onboarding #1549
Merged
dekkers
merged 62 commits into
main
from
fix/redteamer-accept-clearance-level-onboarding
Aug 15, 2023
Merged
Redteamer can now acknowledge clearance level during onboarding #1549
dekkers
merged 62 commits into
main
from
fix/redteamer-accept-clearance-level-onboarding
Aug 15, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ture/clearance-levels-at-redteam-creation
….com:minvws/nl-kat-coordination into feature/clearance-levels-at-redteam-creation
…/redteamer-accept-clearance-level-onboarding
…ture/clearance-levels-at-redteam-creation
….com:minvws/nl-kat-coordination into feature/clearance-levels-at-redteam-creation
….com:minvws/nl-kat-coordination into fix/redteamer-accept-clearance-level-onboarding
…hub.com:minvws/nl-kat-coordination into fix/redteamer-accept-clearance-level-onboarding
Checklist for QA:
Nice work! What works:
What doesn't work:
Bug or feature?:
|
dekkers
reviewed
Aug 11, 2023
…rdination into fix/redteamer-accept-clearance-level-onboarding
…rdination into fix/redteamer-accept-clearance-level-onboarding
Re-tested. Fix confirmed! :) |
…/redteamer-accept-clearance-level-onboarding
…hub.com:minvws/nl-kat-coordination into fix/redteamer-accept-clearance-level-onboarding
dekkers
approved these changes
Aug 15, 2023
jpbruinsslot
added a commit
that referenced
this pull request
Aug 22, 2023
* main: Use 127.0.0.1 for RabbitMQ in install script (#1644) Remove environment variables from container docs (#1645) Feature/report generation timeout (#1640) Add reverse DNS boefje (#1579) Add first version of new normalisers runner design (#1538) Fix `poetry-dependencies` target in Makefile (#1627) Upgrade OpenTelemetry (#1626) Remove finding types from rocky/OOI_database_seed.json (#1619) Feature: Add task detail pages and show objects yielded by normalizer (#1506) Update django-admin-auto-tests (#1617) Update GitHub Actions (#1618) Updated cryptography (#1615) Improve filter by muted findings on findings page (#1595) Redteamer can now acknowledge clearance level during onboarding (#1549) Do not add line information in `.po` files (#1616) Add TLS Cipher checks (#1381)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Issue link
Closes #908
Proof
This step has been splitted now (introduction about clearance levels)
NEW added screen that talks about the clearance level permissions and acknowledging
Here a redteamer does not have enough clearance to continue onboarding
Screen to accept onboarding or just skip
After accepting, now one can continue onboarding
Setting clearance level comes afterwards, only focusses on setting the clearance level:
Code Checklist
Communication
.env
changes files if required and changed the.env-dist
accordingly.Checklist for code reviewers:
Copy-paste the checklist from the docs/source/templates folder into your comment.
Checklist for QA:
Copy-paste the checklist from the docs/source/templates folder into your comment.