Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Withdraw clearance level must have a value of -1 instead of 0 #1531

Merged
merged 2 commits into from
Aug 1, 2023

Conversation

Rieven
Copy link
Contributor

@Rieven Rieven commented Aug 1, 2023

Changes

Change value to -1 instead of 0 for withdrawing clearance level

Issue link

#1529

Closes #1529


Code Checklist

  • All the commits in this PR are properly PGP-signed and verified;
  • This PR only contains functionality relevant to the issue; tickets have been created for newly discovered issues.
  • I have written unit tests for the changes or fixes I made.
  • For any non-trivial functionality, I have added integration and/or end-to-end tests.
  • I have performed a self-review of my code and refactored it to the best of my abilities.

Checklist for code reviewers:

Copy-paste the checklist from the docs/source/templates folder into your comment.


Checklist for QA:

Copy-paste the checklist from the docs/source/templates folder into your comment.

@Rieven Rieven requested a review from a team as a code owner August 1, 2023 13:11
@underdarknl underdarknl merged commit 4b76497 into main Aug 1, 2023
@underdarknl underdarknl deleted the fix/withdraw-clearance-level branch August 1, 2023 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Withdraw clearance level must be set back to -1 instead of 0
3 participants