Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify workflow to run make poetry-dependencies on Dependabot PR's and commit it #1348

Merged
merged 3 commits into from
Jul 6, 2023
Merged

Modify workflow to run make poetry-dependencies on Dependabot PR's and commit it #1348

merged 3 commits into from
Jul 6, 2023

Conversation

Darwinkel
Copy link
Contributor

Small workflow file that should make sure that Dependabot PR's also export relevant requirements.txt files.

@Darwinkel Darwinkel requested a review from a team as a code owner July 6, 2023 07:32
@Darwinkel Darwinkel changed the title Add workflow to run make poetry-dependencies on Dependabot PR's Modify workflow to run make poetry-dependencies on Dependabot PR's and commit it Jul 6, 2023
ammar92
ammar92 approved these changes Jul 6, 2023
View reviewed changes
Copy link
Contributor

@ammar92 ammar92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. You could also set an env var on job level (e.g. DEPENDABOT: ${{ github.actor == 'dependabot[bot]' }} and then use this condition in the ifs: if: env.DEPENDABOT

@dekkers dekkers merged commit 165b930 into main Jul 6, 2023
@dekkers dekkers deleted the feature/dependabot-poetry-exports branch July 6, 2023 09:20
jpbruinsslot added a commit that referenced this pull request Jul 6, 2023
@jpbruinsslot
Merge branch 'main' into feature/mula/disabling-schedulers
a87d462 
* main:
  Modify workflow to run `make poetry-dependencies` on Dependabot PR's and commit it (#1348)
  Remove unused max_plugin_runtime configuration variable (#1346)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ammar92 ammar92 ammar92 approved these changes

@dekkers dekkers dekkers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Darwinkel @dekkers @ammar92