Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpin typing-extensions dependency #1089

Merged
merged 4 commits into from
Jun 5, 2023
Merged

Conversation

praseodym
Copy link
Contributor

Changes

Unpin typing-extensions dependency, this is no longer needed now that Pydantic is updated.

Issue link

n/a

Proof

n/a

Code Checklist

  • All the commits in this PR are properly PGP-signed and verified;
  • This PR only contains functionality relevant to the issue; tickets have been created for newly discovered issues.
  • I have written unit tests for the changes or fixes I made.
  • For any non-trivial functionality, I have added integration and/or end-to-end tests.
  • I have performed a self-review of my code and refactored it to the best of my abilities.

Communication

  • I have informed others of any required .env changes files if required and changed the .env-dist accordingly.
  • I have made corresponding changes to the documentation, if necessary.

Checklist for code reviewers:

Copy-paste the checklist from the docs/source/templates folder into your comment.


Checklist for QA:

Copy-paste the checklist from the docs/source/templates folder into your comment.

No longer needed now that Pydantic is updated.
@praseodym praseodym requested a review from a team as a code owner June 1, 2023 10:03
@dekkers dekkers merged commit 5ca80fd into main Jun 5, 2023
@dekkers dekkers deleted the chore/remove-typing-extensions-pin branch June 5, 2023 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants