Fix phony targets in Makefile #1055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only goals that were passed to Make were considered phony, meaning that `make build` would not do anything when a file or directory named `build` existed. More information on phony targets: https://www.gnu.org/software/make/manual/html_node/Phony-Targets.html
dekkers
approved these changes
May 25, 2023
jpbruinsslot
added a commit
that referenced
this pull request
May 30, 2023
* main: Bump sphinx-rtd-theme from 1.2.0 to 1.2.1 (#1062) Clients can start scans on objects without changing clearance (#945) Add date, name and status filters (#572) Fix clearance level views (#1035) Add 1.9 release notes (#1029) Fix scheduler ranking (#988) Fix phony targets in Makefile (#1055) Bump mmh3 from 3.0.0 to 4.0.0 (#1005)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Only goals that were passed to Make were considered phony, meaning that
make buildwould not do anything when a file or directory namedbuildexisted.More information on phony targets:
https://www.gnu.org/software/make/manual/html_node/Phony-Targets.html
Issue link
n/a, @Darwinkel was hitting this issue today
Proof
n/a
Code Checklist
Communication
.envchanges files if required and changed the.env-distaccordingly.Checklist for code reviewers:
Copy-paste the checklist from the docs/source/templates folder into your comment.
Checklist for QA:
Copy-paste the checklist from the docs/source/templates folder into your comment.