Skip to content
This repository has been archived by the owner on Nov 4, 2024. It is now read-only.

feature/COR-1938-update-format-intial-tick-date #5003

Merged

Conversation

ben-van-eekelen
Copy link
Contributor

Summary

  • Reformat the first dateTick on selecting timeframe 'show all' to also include a day

Screenshots

Before

Toggle before screenshots

image

After

Toggle after screenshots

image

Copy link
Contributor

@VWSCoronaDashboard30 VWSCoronaDashboard30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice refactoring!

@ben-van-eekelen ben-van-eekelen merged commit 12af9a8 into develop Mar 11, 2024
8 checks passed
@ben-van-eekelen ben-van-eekelen deleted the feature/COR-1938-update-format-intial-tick-date branch March 11, 2024 16:05
VWSCoronaDashboard30 added a commit that referenced this pull request Mar 22, 2024
* feature/COR-1938-update-format-intial-tick-date (#5003)

* refactor(COR-1938): Make comments JSDoc compliant

* refactor: reorder

* refactor: reorder

* feat(COR-1938): Set dateformat of first tick to include date

* feature(COR-1951): Corrected time frame option values

---------

Co-authored-by: Ben van Eekelen (work) <ben.vaneekelen@netcompany.com>
VWSCoronaDashboard30 added a commit that referenced this pull request Mar 22, 2024
* feat(COR-1953/COR-1952): Added new metadata fields

* feat(COR-1952/COR-1953): Added lokalize keys

* feat(COR-1953): Added corrections for rioolwater NL and infectieradar pages (#5005)

* feature/COR-1954-consolidate-metadata (#5007)

* feat(COR-1954): Initial copy-paste merging

* feat(COR-1954): Add JSDoc comments

* feat(COR-1954): Fix empty source showing up

* feat(COR-1954): Replace source with metadataItem

* feat(COR-1954): Turn datelastinserted date into MetadataItem

* feat(COR-1954): Consolidated metadataprops type into seperate type file

* feat(COR-1954) Split up and combine into module

* feat(COR-1954): Substitute clock on pageinfoblock with metadataitem

* feature/COR-1953_non-archived-graphs-adjustments (#5008)

* feat(COR-1953): Added corrections for rioolwater NL and infectieradar pages

* feature(COR-1953): Adjustments for metadata and time-series-chart components

* feature(COR-1953): Adjustments for rioolwater page

* feature(COR-1953): Adjustments for NL variants page

* feature(COR-1953): Adjustments for NL infectieradar page

* feature(COR-1953): Adjustments for GM stertfe page

* feature(COR-1953): Adjustments for GM positive tests page

* feature(COR-1953): Adjustments for GM patienten-in-beeld page

* feature(COR-1953): Adjustments for NL de-coronaprik page

* feature(COR-1953): Adjustments for NL de-coronaprik component indentation

* feature(COR-1953): Adjustments for NL infectieradar page components

* feature(COR-1953): Adjustments for NL positive tests page

* feature(COR-1953): Adjustments for NL besmettelijke-mensen page

* feature(COR-1953): Adjustments for NL coronamelder page

* feature(COR-1953): Adjustments for NL gedrag page

* feature(COR-1953): Adjustments for NL gehandicaptenzorg page

* feature(COR-1953): Adjustments for NL klachten-bij-huisartsen page

* feature(COR-1953): Adjustments for NL kwetsbare-groepen-70-plussers page

* feature(COR-1953): Adjustments for NL patienten-in-beeld page

* feature(COR-1953): Adjustments for NL sterfte page

* feature(COR-1953): Adjustments for NL thuiswonende-70-plussers page

* feature(COR-1953): Adjustments for NL ziekenhuizen-in-beeld page

* feature(COR-1953): Adjustments for NL ziekenhuizen-in-beeld page import order

* feature(COR-1953): Fixed sewer branch last insertion date not displaying

* feature(COR-1953): Attempt to sign commit

* feature(COR-1953): Reverting change for commit signing test

* feature(COR-1953): Fixed rioolwater pageinformationblock not displaying last update

* feat(COR-1953): Rename timeInterval to timeframePeriod

* Revert "feat(COR-1953): Rename timeInterval to timeframePeriod"

This reverts commit 4c3b077.

* feature(COR-1953): Renamed timeInterval/TimeInterval to timeframePeriod/TimeframePeriod

---------

Co-authored-by: VWSCoronaDashboard29 <ben.vaneekelen@netcompany.com>

* feature/COR-1951_dropdown-options-selection-changes (#5010)

* feature/COR-1938-update-format-intial-tick-date (#5003)

* refactor(COR-1938): Make comments JSDoc compliant

* refactor: reorder

* refactor: reorder

* feat(COR-1938): Set dateformat of first tick to include date

* feature(COR-1951): Corrected time frame option values

---------

Co-authored-by: Ben van Eekelen (work) <ben.vaneekelen@netcompany.com>

* feature/COR-1956_make-metadata-consistent (#5011)

* feat(COR-1953): Added corrections for rioolwater NL and infectieradar pages

* feature(COR-1953): Adjustments for metadata and time-series-chart components

* feature(COR-1953): Adjustments for rioolwater page

* feature(COR-1953): Adjustments for NL variants page

* feature(COR-1953): Adjustments for NL infectieradar page

* feature(COR-1953): Adjustments for GM stertfe page

* feature(COR-1953): Adjustments for GM positive tests page

* feature(COR-1953): Adjustments for GM patienten-in-beeld page

* feature(COR-1953): Adjustments for NL de-coronaprik page

* feature(COR-1953): Adjustments for NL de-coronaprik component indentation

* feature(COR-1953): Adjustments for NL infectieradar page components

* feature(COR-1953): Adjustments for NL positive tests page

* feature(COR-1953): Adjustments for NL besmettelijke-mensen page

* feature(COR-1953): Adjustments for NL coronamelder page

* feature(COR-1953): Adjustments for NL gedrag page

* feature(COR-1953): Adjustments for NL gehandicaptenzorg page

* feature(COR-1953): Adjustments for NL klachten-bij-huisartsen page

* feature(COR-1953): Adjustments for NL kwetsbare-groepen-70-plussers page

* feature(COR-1953): Adjustments for NL patienten-in-beeld page

* feature(COR-1953): Adjustments for NL sterfte page

* feature(COR-1953): Adjustments for NL thuiswonende-70-plussers page

* feature(COR-1953): Adjustments for NL ziekenhuizen-in-beeld page

* feature(COR-1953): Adjustments for NL ziekenhuizen-in-beeld page import order

* feature(COR-1953): Fixed sewer branch last insertion date not displaying

* feature(COR-1953): Attempt to sign commit

* feature(COR-1953): Reverting change for commit signing test

* feature(COR-1953): Fixed rioolwater pageinformationblock not displaying last update

* feat(COR-1953): Rename timeInterval to timeframePeriod

* Revert "feat(COR-1953): Rename timeInterval to timeframePeriod"

This reverts commit 4c3b077.

* feature(COR-1953): Renamed timeInterval/TimeInterval to timeframePeriod/TimeframePeriod

* feature(COR-1956): Adjusted KPI's and Choropleths to new metadata

---------

Co-authored-by: VWSCoronaDashboard29 <ben.vaneekelen@netcompany.com>

* feature/COR-1952_archived-graphs-adjustments (#5009)

* feature(COR-1952): Corrected archived graphs for NL variants page

* feature(COR-1952): Corrected archived graphs for NL sterfte page

* feature(COR-1952): Corrected archived graphs for NL kwetsbare-groepen-70-plussers page

* feature(COR-1952): Corrected archived graphs for NL reproductiegetal page

* feature(COR-1952): Corrected archived graphs for NL positieve-testen page

* feature(COR-1952): Corrected archived graphs for NL gehandicaptenzorg page

* feature(COR-1952): Corrected archived graphs for NL thuiswonende-70-plussers page

* feature(COR-1952): Corrected archived graphs for NL coronamelder page

* feature(COR-1952): Corrected archived graphs for GM positieve-testen page

* feature(COR-1952): Corrected archived graphs for GM sterfte page

* feature(COR-1952): Corrected archived graphs for GM patienten-in-beeld page

* feature(COR-1952): Added missing metadata for patienten-in-beeld

---------

Co-authored-by: Ben van Eekelen (work) <ben.vaneekelen@netcompany.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants