This repository has been archived by the owner on Nov 4, 2024. It is now read-only.
feature/COR-1597-contact-page-improved-design #4873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for the new design.
… type of an items title. Also added some UX improvements to hide the field unless it needs to be filled.
APW26
commented
Sep 18, 2023
APW26
requested review from
Jorrik-Klijnsma-Work,
DariaKwork,
VWSCoronaDashboard30 and
ben-van-eekelen
ben-van-eekelen
approved these changes
Sep 19, 2023
DariaKwork
approved these changes
Sep 19, 2023
ben-van-eekelen
pushed a commit
that referenced
this pull request
Oct 3, 2023
This reverts commit dae12d5.
ben-van-eekelen
pushed a commit
that referenced
this pull request
Oct 4, 2023
This reverts commit dae12d5.
ben-van-eekelen
pushed a commit
that referenced
this pull request
Oct 4, 2023
This reverts commit dae12d5.
ben-van-eekelen
pushed a commit
that referenced
this pull request
Oct 6, 2023
This reverts commit dae12d5.
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
<ContentLayout>which is now used on content pages like: About, FAQ, and Contact.MarginPropsto avoid having to constantly wrap those components in boxes to space them out.The feature works by dividing the contact page into groups and items. Items belong to groups, and the groups belong to the Contact page document in Sanity. Each group has a list of items which are connected to it by the way the schemas are built in Sanity (using references), no additional logic is required to link items and groups. The order of appearance of groups can be controlled in Sanity as well.
Screenshots
Before
Toggle before screenshots
After
Toggle after screenshots