Skip to content
This repository has been archived by the owner on Nov 4, 2024. It is now read-only.

task: Remove add new document button in navbar #4868

Conversation

Jorrik-Klijnsma-Work
Copy link
Contributor

@Jorrik-Klijnsma-Work Jorrik-Klijnsma-Work commented Sep 14, 2023

Summary

  • This is already deployed to Sanity Studio.
  • Sanity gives you no control over this part of the navbar.
  • The only way to remove this icon and functionality is 'really' dirty, by injecting some CSS and returning an empty array.

Screenshots

Before

Toggle before screenshots

Screenshot 2023-09-14 at 10 21 15

After

Toggle after screenshots Screenshot 2023-09-14 at 10 20 27

Copy link
Contributor

@APW26 APW26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this have been tested by someone else before being deployed?

@Jorrik-Klijnsma-Work Jorrik-Klijnsma-Work merged commit 4153337 into develop Sep 14, 2023
7 checks passed
@Jorrik-Klijnsma-Work Jorrik-Klijnsma-Work deleted the feature/COR-1669-Remove-the-new-document-button-in-Sanity branch September 14, 2023 12:41
ben-van-eekelen added a commit that referenced this pull request Oct 2, 2023
* feat(COR-1801): Finalized ticket

* fix(zks-graphs): Fixed range dates to date (#4865)

* fix(zks-graphs): Fixed range dates to date

* fix(1806): Updated documentation

* task: Remove add new document button in navbar (#4868)

* Feature/cor 1563 refactor text keys in kpi to markdown (#4867)

* fix: deleted unused component

* fix: Create markdown consistency in KPI tiles

* Bugfix/cor 1769 variants table and graph 2 (#4870)

* fix(COR-1769): Removed keys from schemas

* fix(COR-1769): Removed historical significance key

* fix(COR-1769): Update getter functions

* fix(COR-1769): Remove unused code from variants chart

* fix(COR-1769): Re-add destructuring based on suggestion

---------

Co-authored-by: VWSCoronaDashboard29 <[email protected]>

* feat(COR-1784): Update schemas to match protos

* feat(COR-1784): Update schemas to protos and fix

* feat(COR-1784): Update branch to match old branch

* feat(COR-1784): Update schema titles

* feat(COR-1784): Adapt vaccine campaign tiles

* feat(COR-1784): Made vaccine coverage generic

* feat(COR-1784): Streamline hook

* feat(COR-1784): Split autumn vaccine per age group table

* feat(COR-1784): Add primary series choropleth and fix keys

* feat(COR-1784): Add campaign banner component

* task: Apply changes from COR-1788

* feat(COR-1784): Add campaign hero

* feat(COR-1784): Update vaccine colours

* feat(COR-1784): Remove barrel files

* feat(COR-1784): Update schema to match protos

* feat(COR-1784): Update conditional display based on feedback

* feat(COR-1784): Add newline in schemafile

* feat(COR-1784): Removed type indication in coverage-per-age-group

* feat(COR-1784): Centralize styling

* fix(COR-1784): Update types to new schemanames

* feat(COR-1784): Reverted conditional component based on feedback

* feat(COR-1784): Update schemas and datatypes to match protos

* feat(COR-1801): Replaced the protos actual values

* feat(COR-1801): Fixed typecheck issues and adjusted the municipality page

* feat(COR-1784): Update vaccines page to new designs spec

* feat(COR-1784): Update pageinfo block for primary series

* task(COR-1784): Check in sanity key mutations

* refactor(COR-1784): Refactor name from feedback

* fix(COR-1784): Change date of primary series pageinfo

* fix(COR-1784): Add optional to metadata

* refactor(COR-1784/COR-1801): Refactored generic types usage

* refactor(COR-1784/COR-1801): refactored ternary operator

* refactor(COR-1784/COR-1801): Refactored the vaccine-campaign-tile

* refactor(COR-1784/COR-1801): Refactored campaign banner

* refactor(COR-1784/COR-1801): Refactor schemanames

* fix(COR-1784/COR-1801): Fix feature flags

* fix(COR-1784/COR-1801): Fix choropleth validation

* refactor(COR-1784/COR-1801): Refactored schema names

---------

Co-authored-by: J <[email protected]>
Co-authored-by: VWSCoronaDashboard29 <[email protected]>
Co-authored-by: VWSCoronaDashboard29 <[email protected]>
Co-authored-by: beek <[email protected]>
Co-authored-by: VWSCoronaDashboard29 <B>
@ben-van-eekelen ben-van-eekelen mentioned this pull request Oct 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants