Skip to content
This repository has been archived by the owner on Nov 4, 2024. It is now read-only.

COR-1660-archive-thermometer #4818

Merged
merged 15 commits into from
Jul 18, 2023
Merged

Conversation

ben-van-eekelen
Copy link
Contributor

Archived the coronadashboard thermometer to it's separate page

@CLAassistant
Copy link

CLAassistant commented Jul 10, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ VWSCoronaDashboard30
❌ beek


beek seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@ben-van-eekelen ben-van-eekelen marked this pull request as ready for review July 11, 2023 07:46
Copy link
Contributor

@Jorrik-Klijnsma-Work Jorrik-Klijnsma-Work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of the comments maybe elaborated on in a separate meeting.

packages/cms/src/lokalize/key-mutations.csv Outdated Show resolved Hide resolved
packages/app/src/queries/query-types.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@APW26 APW26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my comments. I also notice some merge conflicts so those need to be fixed too.

APW26
APW26 previously approved these changes Jul 18, 2023
Copy link
Contributor

@Amber-Taal-Work Amber-Taal-Work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome job!

Copy link
Contributor

@Jorrik-Klijnsma-Work Jorrik-Klijnsma-Work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@VWSCoronaDashboard30 VWSCoronaDashboard30 changed the title Cor 1660 archive thermometer COR-1660-archive-thermometer Jul 18, 2023
@VWSCoronaDashboard30 VWSCoronaDashboard30 merged commit 77d92ce into develop Jul 18, 2023
@VWSCoronaDashboard30 VWSCoronaDashboard30 deleted the COR-1660-archive-thermometer branch July 18, 2023 13:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants