Skip to content
This repository has been archived by the owner on Nov 4, 2024. It is now read-only.

feature/COR-1684-archive-reproduction-number #4809

Merged
merged 5 commits into from
Jul 12, 2023
Merged

feature/COR-1684-archive-reproduction-number #4809

merged 5 commits into from
Jul 12, 2023

Conversation

Amber-Taal-Work
Copy link
Contributor

Summary

  • Moved 'Reproductiegetal' page in the archived pages section, at the top of the archived pages list.
  • Changed the section sub-title.
  • Added warning tile.
  • Any metrics are marked as archived as per the new archive system.

Screenshots

Before

Toggle before screenshots

Scherm­afbeelding 2023-07-06 om 14 53 33

After

Toggle after screenshots

Scherm­afbeelding 2023-07-06 om 14 53 10

@Amber-Taal-Work Amber-Taal-Work changed the title Feature/cor 1684 archive reproduction number feature/COR-1684-archive-reproduction-number Jul 6, 2023
@Amber-Taal-Work Amber-Taal-Work marked this pull request as ready for review July 6, 2023 13:31
APW26
APW26 reviewed Jul 6, 2023
View reviewed changes
Copy link
Contributor

@APW26 APW26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but please see my comment

Jorrik-Klijnsma-Work
Jorrik-Klijnsma-Work previously approved these changes Jul 7, 2023
View reviewed changes
Copy link
Contributor

@Jorrik-Klijnsma-Work Jorrik-Klijnsma-Work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Good stuff!

@Amber-Taal-Work Amber-Taal-Work added the Awaiting Data Blocked from QA due to missing data label Jul 10, 2023
DariaKwork
DariaKwork previously approved these changes Jul 12, 2023
View reviewed changes
Jorrik-Klijnsma-Work
Jorrik-Klijnsma-Work approved these changes Jul 12, 2023
View reviewed changes
Copy link
Contributor

@Jorrik-Klijnsma-Work Jorrik-Klijnsma-Work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice that you removed this unused timeline!

APW26
APW26 approved these changes Jul 12, 2023
View reviewed changes
Copy link
Contributor

@APW26 APW26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@Amber-Taal-Work Amber-Taal-Work added Hold This should not be merged (yet) and removed Hold This should not be merged (yet) Awaiting Data Blocked from QA due to missing data labels Jul 12, 2023
@Amber-Taal-Work Amber-Taal-Work merged commit e085021 into develop Jul 12, 2023
@Amber-Taal-Work Amber-Taal-Work deleted the feature/COR-1684-archive-reproduction-number branch July 12, 2023 13:22
@VWSCoronaDashboard30 VWSCoronaDashboard30 mentioned this pull request Jul 18, 2023
Merged
@APW26 APW26 mentioned this pull request Jul 31, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@APW26 APW26 APW26 approved these changes

@Jorrik-Klijnsma-Work Jorrik-Klijnsma-Work Jorrik-Klijnsma-Work approved these changes

@DariaKwork DariaKwork DariaKwork left review comments

@VWSCoronaDashboard30 VWSCoronaDashboard30 Awaiting requested review from VWSCoronaDashboard30

@ben-van-eekelen ben-van-eekelen Awaiting requested review from ben-van-eekelen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Amber-Taal-Work @Jorrik-Klijnsma-Work @DariaKwork @APW26