This repository has been archived by the owner on Nov 4, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 45
feature/COR-1601-articles-overview-improved-design #4807
Merged
APW26
merged 10 commits into
develop
from
feature/COR-1601-articles-overview-improved-design
Jul 7, 2023
Merged
feature/COR-1601-articles-overview-improved-design #4807
APW26
merged 10 commits into
develop
from
feature/COR-1601-articles-overview-improved-design
Jul 7, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…w things, add a new component, some styling changes.
APW26
requested review from
Jorrik-Klijnsma-Work,
Amber-Taal-Work,
DariaKwork,
VWSCoronaDashboard30 and
ben-van-eekelen
July 3, 2023 15:28
Amber-Taal-Work
previously approved these changes
Jul 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
packages/app/src/components/articles/article-update-or-publishing-date.tsx
Show resolved
Hide resolved
Jorrik-Klijnsma-Work
previously approved these changes
Jul 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great! With only a minor comment
packages/app/src/components/articles/article-update-or-publishing-date.tsx
Show resolved
Hide resolved
DariaKwork
previously approved these changes
Jul 6, 2023
APW26
dismissed stale reviews from DariaKwork, Jorrik-Klijnsma-Work, and Amber-Taal-Work
via
July 6, 2023 12:57
c1a4fbd
VWSCoronaDashboard30
approved these changes
Jul 6, 2023
Amber-Taal-Work
approved these changes
Jul 6, 2023
Jorrik-Klijnsma-Work
approved these changes
Jul 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good!!
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Screenshots
Before
Toggle before screenshots
For some reason I cannot add before screenshots of the overview, please visit the articles page on production to see this.After
Toggle after screenshots
For some reason I cannot add after screenshots of the overview, please run this locally to see it.Updated date shown on Article Detail page if available
New fields in Sanity