Skip to content
This repository has been archived by the owner on Nov 4, 2024. It is now read-only.

feature/COR-1521-vulnerable-groups-page-optimizations-2 #4755

Merged
merged 16 commits into from
Apr 24, 2023
Merged

feature/COR-1521-vulnerable-groups-page-optimizations-2 #4755

merged 16 commits into from
Apr 24, 2023

Conversation

Amber-Taal-Work
Copy link
Contributor

@Amber-Taal-Work Amber-Taal-Work commented Apr 24, 2023 •
edited
Loading

Summary

  • Deleted KPI
  • Deleted PageInformationBlocks
  • Deleted unused Sanity Keys
  • Created BorderedKpiSection
  • Replaced VaccineCoverageTile, HospitalsTile and InfectLocationsTile with BorderedKpiSection
  • Deleted unused Icon ElderlyPeople
  • Archived data for KPI
  • Fixed a bug which caused the PercentageBar not showing

Screenshots

Before

Toggle before screenshots

Scherm­afbeelding 2023-04-18 om 17 04 47

Scherm­afbeelding 2023-04-18 om 17 04 54

Percentagebar bug
Scherm­afbeelding 2023-04-24 om 15 08 42

After

Toggle after screenshots

after-vulnerable-groups

Percentagebar
after_percentagebar

@Amber-Taal-Work Amber-Taal-Work changed the title Feature/cor 1521 vulnerable groups page optimizations 2 feature/COR-1521-vulnerable-groups-page-optimizations-2 Apr 24, 2023
@Amber-Taal-Work Amber-Taal-Work marked this pull request as ready for review April 24, 2023 13:17
VWSCoronaDashboard26
VWSCoronaDashboard26 approved these changes Apr 24, 2023
View reviewed changes
Copy link
Contributor

@VWSCoronaDashboard26 VWSCoronaDashboard26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG2M! :shipit:

@Amber-Taal-Work Amber-Taal-Work merged commit a4a9741 into develop Apr 24, 2023
@Amber-Taal-Work Amber-Taal-Work deleted the feature/COR-1521-vulnerable-groups-page-optimizations-2 branch April 24, 2023 15:02
@Jorrik-Klijnsma-Work Jorrik-Klijnsma-Work mentioned this pull request Apr 24, 2023
Merged
@Amber-Taal-Work Amber-Taal-Work mentioned this pull request Apr 25, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Jorrik-Klijnsma-Work Jorrik-Klijnsma-Work Jorrik-Klijnsma-Work left review comments

@APW26 APW26 APW26 approved these changes

@VWSCoronaDashboard26 VWSCoronaDashboard26 VWSCoronaDashboard26 approved these changes

@VWSCoronaDashboard25 VWSCoronaDashboard25 Awaiting requested review from VWSCoronaDashboard25

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Amber-Taal-Work @Jorrik-Klijnsma-Work @VWSCoronaDashboard25 @VWSCoronaDashboard26 @APW26