-
Notifications
You must be signed in to change notification settings - Fork 45
feat: COR-1547 archived National and Municipalities Positive tests pages #4751
feat: COR-1547 archived National and Municipalities Positive tests pages #4751
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see my comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also noticed that the Typecheck action fails. Something to do with the warning text. Could you double check whats happening there by running yarn typecheck
locally?
packages/app/src/pages/gemeente/[code]/positief-geteste-mensen.tsx
Outdated
Show resolved
Hide resolved
packages/app/src/pages/gemeente/[code]/positief-geteste-mensen.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two small additional comments
packages/app/src/pages/gemeente/[code]/positief-geteste-mensen.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
f39a48b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I liked the previous version better! 😁
But this is okay as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Let's go!
Summary
Done
In edition
Screenshots
Before
Toggle before screenshot
After
Toggle after screenshot