Skip to content
This repository has been archived by the owner on Nov 4, 2024. It is now read-only.

feat: COR-1547 archived National and Municipalities Positive tests pages #4751

Merged
merged 12 commits into from
Apr 24, 2023

Conversation

DariaKwork
Copy link
Contributor

@DariaKwork DariaKwork commented Apr 19, 2023

Summary

Done

  • Place on National and Municipalities "Positive Tests" pages in the archived section in nl-layout.tsx and gm-layout.tsx.
  • Change sub-title of "Positive Tests" page "Ontwikkeling van het virus" => "Gearchiveerde pagina's" on National and Municipalities levels.
  • Added right under the introduction of the page - a grey notification bar, to indicate the page is archived on National and Municipalities levels.
  • Remove first graph "Zelfgerapporteerde positieve coronatestuitslagen" from the archived page, as this graph will still be displayed at the new "Testen" page on National level.
  • Removed the "Gearchiveerde grafieken" section with button and kept the "Positieve testen groeigetal" graph that appeared after clicking.
  • VR connections was removed from NL positief-geteste-mensen.tsx

In edition

  • Grey notification bars on NL level at "Positieve testen groeigetal" and "Positieve GGD tests over time" sections can be removed by communication.

Screenshots

Before

Toggle before screenshot

Screenshot 2023-04-19 at 11 29 29
Screenshot 2023-04-19 at 11 30 49

After

Toggle after screenshot

Screenshot 2023-04-19 at 11 27 33
Screenshot 2023-04-19 at 11 31 36

Copy link
Contributor

@APW26 APW26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my comments

packages/app/src/components/chart-tile-toggle.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@APW26 APW26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also noticed that the Typecheck action fails. Something to do with the warning text. Could you double check whats happening there by running yarn typecheck locally?

@DariaKwork DariaKwork added Hold This should not be merged (yet) Awaiting Data Blocked from QA due to missing data labels Apr 19, 2023
@VWSCoronaDashboard26 VWSCoronaDashboard26 removed Hold This should not be merged (yet) Awaiting Data Blocked from QA due to missing data labels Apr 24, 2023
APW26
APW26 previously approved these changes Apr 24, 2023
Copy link
Contributor

@APW26 APW26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small additional comments

Copy link
Contributor

@VWSCoronaDashboard25 VWSCoronaDashboard25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@DariaKwork DariaKwork dismissed stale reviews from VWSCoronaDashboard25 and APW26 via f39a48b April 24, 2023 13:58
Copy link
Contributor

@VWSCoronaDashboard25 VWSCoronaDashboard25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I liked the previous version better! 😁
But this is okay as well.

Copy link
Contributor

@Jorrik-Klijnsma-Work Jorrik-Klijnsma-Work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Let's go!

@DariaKwork DariaKwork merged commit 294b5d9 into develop Apr 24, 2023
@DariaKwork DariaKwork deleted the feature/COR-1547-archiving-positive-tests-page branch April 24, 2023 14:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants