This repository has been archived by the owner on Nov 4, 2024. It is now read-only.
feature/COR-1516-404-page-improvements-multiple-pages--fix #4746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
March 24, 2023 15:58
… it closes upon selecting an icon.
…ages are built at runtime.
VWSCoronaDashboard25
deleted the
feature/COR-1516-404-page-improvements-multiple-pages
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
rewrites.js.basePath/404./404like/500is a reserved route and therefore if you were to try to go tobasePath/404on the development environment (before this PR is merged) it would take you to the default_error.tsxpage. The chances that someone would find themselves at/404are low, but its still an edge case so its probably good to have it covered.Screenshots
No new screenshots, if you'd like to see them, you can visit this link.