This repository has been archived by the owner on Nov 4, 2024. It is now read-only.
feature/COR-1548-tests-page #4743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…TestedPeople route component to remove self tests chart; updated reverse router to add new Tests route and clean up; updated NlLayout component to add new Tests route to sidebar; moved Sanity keys using DELETE and ADD; updated types;
VWSCoronaDashboard26
requested review from
Jorrik-Klijnsma-Work,
Amber-Taal-Work,
VWSCoronaDashboard25,
DariaKwork and
APW26
APW26
previously approved these changes
Apr 17, 2023
Jorrik-Klijnsma-Work
previously approved these changes
Apr 17, 2023
VWSCoronaDashboard26
dismissed stale reviews from Jorrik-Klijnsma-Work and APW26
via
de25095
Jorrik-Klijnsma-Work
previously approved these changes
Apr 17, 2023
VWSCoronaDashboard26
dismissed stale reviews from Jorrik-Klijnsma-Work and APW26
via
b4ffbb8
APW26
approved these changes
Apr 21, 2023
DariaKwork
approved these changes
Apr 21, 2023
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Testsroute component;PositivelyTestedPeopleroute component to remove self tests chart;NlLayoutcomponent to add new Tests route ('/landelijk/testen') to sidebar;Notes
PositivelyTestedPeopleroute in order to also clean up associated Sanity keys. However, this pull request does not include any additional archiving of this route as that is to be picked up as part of COR-1547.Testsroute. This can be found in Sanity > Dashboard Pagina's > Testen > nl > various keys.Screenshots
Before
No before screenshots apply as this is a completely new page.
After
Toggle after screenshots