This repository has been archived by the owner on Nov 4, 2024. It is now read-only.
feature/COR-1202-severity-indicator-relative-timeline-parts #4737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ount of days for a timeline bar part; added utility method for calculating the relative width of a timeline bar part; updated Timeline component to leverage new utility methods;
VWSCoronaDashboard26
requested review from
Jorrik-Klijnsma-Work,
Amber-Taal-Work,
VWSCoronaDashboard25,
DariaKwork and
APW26
packages/app/src/components/severity-indicator-tile/components/timeline/timeline.tsx
Outdated
Show resolved
Hide resolved
Jorrik-Klijnsma-Work
previously approved these changes
Apr 13, 2023
APW26
reviewed
Apr 14, 2023
...c/components/severity-indicator-tile/components/timeline/logic/get-timeline-bar-part-days.ts
Outdated
Show resolved
Hide resolved
APW26
reviewed
Apr 14, 2023
packages/app/src/components/severity-indicator-tile/components/timeline/timeline.tsx
Outdated
Show resolved
Hide resolved
… file as all individual utilities are very small yet depent on each other; cleaned up JSX a bit;
APW26
previously approved these changes
Apr 17, 2023
packages/app/src/components/severity-indicator-tile/components/timeline/logic.ts
Outdated
Show resolved
Hide resolved
packages/app/src/components/severity-indicator-tile/components/timeline/logic.ts
Outdated
Show resolved
Hide resolved
packages/app/src/components/severity-indicator-tile/components/timeline/logic.ts
Outdated
Show resolved
Hide resolved
packages/app/src/components/severity-indicator-tile/components/timeline/logic.ts
Show resolved
Hide resolved
packages/app/src/components/severity-indicator-tile/components/timeline/logic.ts
Show resolved
Hide resolved
Jorrik-Klijnsma-Work
previously approved these changes
Apr 17, 2023
packages/app/src/components/severity-indicator-tile/components/timeline/logic.ts
Show resolved
Hide resolved
packages/app/src/components/severity-indicator-tile/components/timeline/logic.ts
Outdated
Show resolved
Hide resolved
packages/app/src/components/severity-indicator-tile/components/timeline/logic.ts
Show resolved
Hide resolved
VWSCoronaDashboard26
dismissed stale reviews from Jorrik-Klijnsma-Work and APW26
via
8090b7f
APW26
approved these changes
Apr 17, 2023
packages/app/src/components/severity-indicator-tile/components/timeline/logic.ts
Show resolved
Hide resolved
Jorrik-Klijnsma-Work
approved these changes
Apr 17, 2023
VWSCoronaDashboard26
deleted the
feature/COR-1202-severity-indicator-relative-timeline-parts
branch
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Screenshots
Screenshots include the development dataset for Sanity and are not a correct representation of the current severity indicator/thermometer. However, it still shows the functionality achieved in this feature: relative widths based on how many days a part (or severity indicator timeline event) spans.
Before
Toggle before screenshots
After
Toggle after screenshots