This repository has been archived by the owner on Nov 4, 2024. It is now read-only.
Feature/COR-1263-table-consistency-implementations #4614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… WIP. Co-authored-by: VWSCoronaDashboard26<[email protected]>
… advice table. Rename some stuff. Extract types to its own file. Co-authored-by: Ros, Luuk <[email protected]>
…ur per age group table.
…g, refactoring, etc.
…orrect typing and some abstraction.
APW26
requested review from
VWSCoronaDashboard26,
Jorrik-Klijnsma-Work,
DariaKwork,
Amber-Taal-Work and
VWSCoronaDashboard25
packages/app/src/components/tables/components/wide-percentage.tsx
Outdated
Show resolved
Hide resolved
packages/app/src/domain/behavior/components/behavior-icon-with-label.tsx
Outdated
Show resolved
Hide resolved
packages/app/src/domain/variants/variants-table-tile/components/percentage-bar-with-number.tsx
Outdated
Show resolved
Hide resolved
packages/app/src/domain/variants/variants-table-tile/components/shared-table-components.tsx
Outdated
Show resolved
Hide resolved
added 4 commits
January 26, 2023 11:44
…s, adding sanity key.
APW26
commented
Jan 26, 2023
There was a problem hiding this comment.
@VWSCoronaDashboard26 and @VWSCoronaDashboard18 I have applied the changes required from your feedback. Some comments which were outdated at the time I went through them were already marked as resolved. I've left the rest unresolved for you to resolve them yourselves if you are happy with the changes.
Amber-Taal-Work
suggested changes
Jan 26, 2023
packages/app/src/domain/variants/variants-table-tile/components/percentage-bar-with-number.tsx
Outdated
Show resolved
Hide resolved
packages/app/src/domain/behavior/components/behavior-icon-with-label.tsx
Outdated
Show resolved
Hide resolved
packages/app/src/components/tables/components/percentage-bar-without-number.tsx
Outdated
Show resolved
Hide resolved
…or the percentage bar column to all relevant tables.
VWSCoronaDashboard26
approved these changes
Jan 27, 2023
Amber-Taal-Work
approved these changes
Jan 31, 2023
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The motivation behind this ticket was to make the tables across the site consistent in terms of design. It was taken one step further by refactoring/removing some components so that there is reduced duplicity of components. This results in quite a few changes, but should help in the long run.
The changes impact the following pages:
The changes impact all the tables on those pages. 2 on the behaviour pages and 3 on the vaccination pages.
Screenshots
NOTE: For the Vaccinations page you see the before and after of only one Vaccine Coverage table. The 2 others are in the archived section and have been made to be exactly the same as the non-archived one. Additionally, in the mobile/narrow screenshots, some of the tables might be cut off due to a lack of vertical screen space when taking a screenshot.
Before - Desktop
Before - Mobile
After - Desktop
After - Mobile