This repository has been archived by the owner on Nov 4, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 45
feature/COR-1369-date-formatting-adjustments #4609
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VWSCoronaDashboard26
requested review from
Jorrik-Klijnsma-Work,
Amber-Taal-Work,
VWSCoronaDashboard25,
DariaKwork and
APW26
January 19, 2023 09:29
APW26
reviewed
Jan 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
APW26
reviewed
Jan 19, 2023
...pp/src/components/severity-indicator-tile/components/timeline/components/tooltip-content.tsx
Show resolved
Hide resolved
APW26
reviewed
Jan 19, 2023
packages/app/src/domain/sewer/sewer-chart/components/location-tooltip.tsx
Show resolved
Hide resolved
APW26
reviewed
Jan 19, 2023
APW26
approved these changes
Jan 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved but please see my comments.
…ng the year to dates, resulting in 'day daynumber month year'; adjusted all files/locations that was either using WeekdayMedium formatting or using no formatting (for examples when dates were part of a text within Sanity);
VWSCoronaDashboard26
force-pushed
the
feature/COR-1369-date-formatting-adjustments
branch
from
January 19, 2023 11:08
543733b
to
def1d6b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my comments
...es/app/src/components/time-series-chart/components/tooltip/tooltip-series-list-container.tsx
Show resolved
Hide resolved
…trics; resolved merge conflicts;
Amber-Taal-Work
approved these changes
Jan 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Nothing blocking, small nitpicky comments.
...es/app/src/components/time-series-chart/components/tooltip/tooltip-series-list-container.tsx
Show resolved
Hide resolved
...ages/app/src/components/time-series-chart/components/timeline/components/tooltip-content.tsx
Show resolved
Hide resolved
...ages/app/src/components/time-series-chart/components/timeline/components/tooltip-content.tsx
Show resolved
Hide resolved
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
WeekdayLong
formatting option for appending the year to dates, resulting in 'day daynumber month year' format;WeekdayMedium
formatting or using no formatting (for examples when dates were part of a text within Sanity);Notes
weekday-long
format or changing existing format styles toweekday-long
; other changes in files are mainly due to Prettier applying its formatting rules;Screenshots
The screenshots only cover bits of the dashboard and give an impression more so than a full overview of everything that has changed. This is because, as you can see, quite a few files have changed (and some files impact even more files).
Before
Toggle before screenshots
After
Toggle after screenshots