Skip to content
This repository has been archived by the owner on Nov 4, 2024. It is now read-only.

Conversation

Jorrik-Klijnsma-Work
Copy link
Contributor

Empty out archived graphs.

Screenshot 2023-01-06 at 14 36 54

Copy link
Contributor

@APW26 APW26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My apologies but I have no context regarding what this PR is about.

@VWSCoronaDashboard26 VWSCoronaDashboard26 force-pushed the feature/deal-with-misssing-GM-archived-data_V2 branch from 872d7e4 to 28b853f Compare January 6, 2023 15:06
Copy link
Contributor

@APW26 APW26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks alright to me, but please do consider the comments mentioned, they would help in the long term.

@DariaKwork
Copy link
Contributor

Code looks good for me.
Maybe add screenshot before OR after?

@VWSCoronaDashboard26 VWSCoronaDashboard26 force-pushed the feature/deal-with-misssing-GM-archived-data_V2 branch from 3f67b99 to 64c3ff7 Compare January 6, 2023 16:40
@VWSCoronaDashboard26 VWSCoronaDashboard26 force-pushed the feature/deal-with-misssing-GM-archived-data_V2 branch from 64c3ff7 to 9f13d5f Compare January 6, 2023 16:41
@VWSCoronaDashboard26 VWSCoronaDashboard26 merged commit 3482369 into feature/cor-1226-municipality-reorganization Jan 6, 2023
@VWSCoronaDashboard26 VWSCoronaDashboard26 deleted the feature/deal-with-misssing-GM-archived-data_V2 branch January 6, 2023 16:49
VWSCoronaDashboard26 added a commit that referenced this pull request Jan 6, 2023
* feat: update schema and documentation

* feat: combine municipalities and add redirects

* chore: cleaned up and updated documentation

* chore: adjust docs and update to current year

* feature/deal-with-misssing-GM-archived-data_V2 (#4598)

* feat(municipality-restructuring): change the schema to remove minItems;
* feat(municipality-restructuring): create empty graph version
* feat(municipality-restructuring): simplified empty data objects approach; fixed TS/compilation issues;

Co-authored-by: VWSCoronaDashboard26 <[email protected]>

Co-authored-by: J <[email protected]>
Co-authored-by: VWSCoronaDashboard26 <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants