This repository has been archived by the owner on Nov 4, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 45
Feature/deal with misssing gm archived data v2 #4598
Merged
VWSCoronaDashboard26
merged 6 commits into
feature/cor-1226-municipality-reorganization
from
feature/deal-with-misssing-GM-archived-data_V2
Jan 6, 2023
Merged
Feature/deal with misssing gm archived data v2 #4598
VWSCoronaDashboard26
merged 6 commits into
feature/cor-1226-municipality-reorganization
from
feature/deal-with-misssing-GM-archived-data_V2
Jan 6, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…And update the archived section on the GM page to alow for now data.
Jorrik-Klijnsma-Work
requested review from
hasan-ozaynaci,
VWSCoronaDashboard26,
DariaKwork and
APW26
January 6, 2023 13:41
APW26
reviewed
Jan 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My apologies but I have no context regarding what this PR is about.
…ach; fixed TS/compilation issues;
VWSCoronaDashboard26
force-pushed
the
feature/deal-with-misssing-GM-archived-data_V2
branch
from
January 6, 2023 15:06
872d7e4
to
28b853f
Compare
APW26
reviewed
Jan 6, 2023
APW26
reviewed
Jan 6, 2023
APW26
approved these changes
Jan 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks alright to me, but please do consider the comments mentioned, they would help in the long term.
Code looks good for me. |
DariaKwork
approved these changes
Jan 6, 2023
VWSCoronaDashboard26
force-pushed
the
feature/deal-with-misssing-GM-archived-data_V2
branch
from
January 6, 2023 16:40
3f67b99
to
64c3ff7
Compare
VWSCoronaDashboard26
force-pushed
the
feature/deal-with-misssing-GM-archived-data_V2
branch
from
January 6, 2023 16:41
64c3ff7
to
9f13d5f
Compare
VWSCoronaDashboard26
merged commit Jan 6, 2023
3482369
into
feature/cor-1226-municipality-reorganization
VWSCoronaDashboard26
deleted the
feature/deal-with-misssing-GM-archived-data_V2
branch
January 6, 2023 16:49
VWSCoronaDashboard26
added a commit
that referenced
this pull request
Jan 6, 2023
* feat: update schema and documentation * feat: combine municipalities and add redirects * chore: cleaned up and updated documentation * chore: adjust docs and update to current year * feature/deal-with-misssing-GM-archived-data_V2 (#4598) * feat(municipality-restructuring): change the schema to remove minItems; * feat(municipality-restructuring): create empty graph version * feat(municipality-restructuring): simplified empty data objects approach; fixed TS/compilation issues; Co-authored-by: VWSCoronaDashboard26 <[email protected]> Co-authored-by: J <[email protected]> Co-authored-by: VWSCoronaDashboard26 <[email protected]>
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Empty out archived graphs.