Skip to content
This repository has been archived by the owner on Nov 4, 2024. It is now read-only.

task/COR-1349-Show sanity debugging tool on staging #4597

Merged
merged 1 commit into from
Jan 6, 2023
Merged

task/COR-1349-Show sanity debugging tool on staging #4597

merged 1 commit into from
Jan 6, 2023

Conversation

APW26
Copy link
Contributor

@APW26 APW26 commented Jan 5, 2023

Summary

The motivation behind this task is to have the sanity debugging tool on the staging environment ASAP.

  • Added a new environment variable for the staging environment URL
  • Removed hard coded reference to an old staging URL in useLokalizeText.tsx
  • Updated the DockerFile and the example env file

task: Added new environment variable for the staging environment URL.…
be687c5 
… Removed the hardcoded staging URL. Updated the DockerFile and the example env file.
@APW26 APW26 self-assigned this Jan 5, 2023
Jorrik-Klijnsma-Work
Jorrik-Klijnsma-Work approved these changes Jan 5, 2023
View reviewed changes
Copy link
Contributor

@Jorrik-Klijnsma-Work Jorrik-Klijnsma-Work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice collaboration of the team!

VWSCoronaDashboard26
VWSCoronaDashboard26 approved these changes Jan 5, 2023
View reviewed changes
Copy link
Contributor

@VWSCoronaDashboard26 VWSCoronaDashboard26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good one on adding a _STG suffix to the URL as well. Makes more sense to use that rather than just NEXT_HOST_URL. 👌

@APW26 APW26 merged commit bc7f275 into develop Jan 6, 2023
@APW26 APW26 deleted the task/COR-1349-show-sanity-debugging-tool-on-staging branch January 6, 2023 10:49
@VWSCoronaDashboard26 VWSCoronaDashboard26 mentioned this pull request Jan 6, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@VWSCoronaDashboard26 VWSCoronaDashboard26 VWSCoronaDashboard26 approved these changes

@Jorrik-Klijnsma-Work Jorrik-Klijnsma-Work Jorrik-Klijnsma-Work approved these changes

@hasan-ozaynaci hasan-ozaynaci hasan-ozaynaci approved these changes

@Amber-Taal-Work Amber-Taal-Work Awaiting requested review from Amber-Taal-Work

Assignees

@APW26 APW26

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@APW26 @hasan-ozaynaci @Jorrik-Klijnsma-Work @VWSCoronaDashboard26