This repository has been archived by the owner on Nov 4, 2024. It is now read-only.
bugfix/COR-1242-labels-overlapping-on-smaller-screen-sizes-for-deaths-chart #4548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt less ticks when date ranges are used, essentially flipping the amount of ticks to be presented based on the existing hasDatesAsRange boolean value;
VWSCoronaDashboard26
requested review from
hasan-ozaynaci,
VWSCoronaDashboard25 and
APW26
VWSCoronaDashboard25
approved these changes
Dec 19, 2022
APW26
approved these changes
Dec 20, 2022
Jorrik-Klijnsma-Work
approved these changes
Dec 20, 2022
VWSCoronaDashboard26
deleted the
bugfix/COR-1242-Labels-overlapping-on-smaller-screen-sizes-for-Deaths-chart
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
preferredDateTickslogic to present less ticks when date ranges are used, essentially flipping the amount of ticks to be presented based on the existinghasDatesAsRangeboolean valueMotivation
In my opinion, it does not make sense to present more ticks for the TimeSeriesChart's
Axescomponent when the values have date ranges. Date ranges, essentially, are longer because they include two dates, two months and optionally one or two years. Showing more ticks while there is theoretically less space, does not work well. Now, the conditions are inverted to only show more ticks where there is actually space for them.Screenshot
Before
After