This repository has been archived by the owner on Nov 4, 2024. It is now read-only.
feature/COR-1260-variants-colour-updates #4537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…riantOrderColors function to filter out variants with an 'other'-prefix; updated VariantStackedAreaTileWithData component to set the default timeframe selection to three months;
VWSCoronaDashboard26
requested review from
hasan-ozaynaci,
Jorrik-Klijnsma-Work and
DariaKwork
APW26
reviewed
Dec 15, 2022
packages/app/src/domain/variants/variants-stacked-area-tile/variants-stacked-area-tile.tsx
Show resolved
Hide resolved
APW26
reviewed
Dec 15, 2022
packages/app/src/domain/variants/variants-stacked-area-tile/variants-stacked-area-tile.tsx
Show resolved
Hide resolved
APW26
approved these changes
Dec 15, 2022
packages/app/src/domain/variants/variants-stacked-area-tile/variants-stacked-area-tile.tsx
Outdated
Show resolved
Hide resolved
packages/app/src/domain/variants/variants-stacked-area-tile/variants-stacked-area-tile.tsx
Outdated
Show resolved
Hide resolved
hasan-ozaynaci
approved these changes
Dec 15, 2022
Jorrik-Klijnsma-Work
approved these changes
Dec 15, 2022
packages/app/src/domain/variants/static-props/get-variant-order-colors.ts
Show resolved
Hide resolved
Jorrik-Klijnsma-Work
suggested changes
Dec 15, 2022
packages/app/src/domain/variants/variants-stacked-area-tile/variants-stacked-area-tile.tsx
Show resolved
Hide resolved
…nt TypeScript issues and remove unused logic;
VWSCoronaDashboard26
deleted the
feature/COR-1260-variants-colour-updates
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
getVariantOrderColorsfunction to filter out variants with an 'other'-prefix;VariantStackedAreaTileWithDatacomponent to set the default timeframe selection to three months;Screenshots
Both screenshots show the complete timeframe and not the updated default selection of three months. This is done to
#D360E5is the new first colour, but this used to be#FFC000, which was skipped);Before
After