Skip to content
This repository has been archived by the owner on Nov 4, 2024. It is now read-only.

feat: restructured logic for internal links #4525

Merged

Conversation

DariaKwork
Copy link
Contributor

@DariaKwork DariaKwork commented Dec 5, 2022

Summary

Before:
Screenshot 2022-12-06 at 13 13 38
Screenshot 2022-12-06 at 13 23 15

After:
Screenshot 2022-12-06 at 13 20 40

Screenshot 2022-12-06 at 13 13 38

@DariaKwork DariaKwork requested review from hasan-ozaynaci, APW26 and Jorrik-Klijnsma-Work and removed request for hasan-ozaynaci and APW26 December 6, 2022 11:09
Copy link
Contributor

@Jorrik-Klijnsma-Work Jorrik-Klijnsma-Work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my earlier review comments

@Jorrik-Klijnsma-Work Jorrik-Klijnsma-Work force-pushed the feature/COR-1193-markdown-interpreter-links-recogniser branch from 27582a0 to 6af6795 Compare December 12, 2022 15:12
APW26
APW26 approved these changes Dec 12, 2022
Copy link
Contributor

@APW26 APW26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please ignore the approval above, Could you adjust the comment in packages/app/src/utils/is-internal-url.ts based on the feedback, please?

Copy link
Contributor

@APW26 APW26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, left one small comment

@Jorrik-Klijnsma-Work Jorrik-Klijnsma-Work force-pushed the feature/COR-1193-markdown-interpreter-links-recogniser branch from 05718c0 to fb69c0e Compare December 15, 2022 14:23
Copy link
Contributor

@Jorrik-Klijnsma-Work Jorrik-Klijnsma-Work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 2 me

@DariaKwork DariaKwork merged commit fae6325 into develop Dec 15, 2022
@DariaKwork DariaKwork deleted the feature/COR-1193-markdown-interpreter-links-recogniser branch December 15, 2022 16:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants