This repository has been archived by the owner on Nov 4, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 45
feat: restructured logic for internal links #4525
Merged
DariaKwork
merged 11 commits into
develop
from
feature/COR-1193-markdown-interpreter-links-recogniser
Dec 15, 2022
Merged
feat: restructured logic for internal links #4525
DariaKwork
merged 11 commits into
develop
from
feature/COR-1193-markdown-interpreter-links-recogniser
Dec 15, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DariaKwork
requested review from
hasan-ozaynaci,
APW26 and
Jorrik-Klijnsma-Work
and removed request for
hasan-ozaynaci and
APW26
December 6, 2022 11:09
APW26
reviewed
Dec 6, 2022
Jorrik-Klijnsma-Work
suggested changes
Dec 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my earlier review comments
Jorrik-Klijnsma-Work
force-pushed
the
feature/COR-1193-markdown-interpreter-links-recogniser
branch
from
December 12, 2022 15:12
27582a0
to
6af6795
Compare
Jorrik-Klijnsma-Work
requested review from
VWSCoronaDashboard26,
APW26 and
Jorrik-Klijnsma-Work
December 12, 2022 15:14
APW26
reviewed
Dec 12, 2022
APW26
reviewed
Dec 12, 2022
APW26
suggested changes
Dec 12, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please ignore the approval above, Could you adjust the comment in packages/app/src/utils/is-internal-url.ts
based on the feedback, please?
APW26
reviewed
Dec 14, 2022
APW26
approved these changes
Dec 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, left one small comment
packages/app/src/components/page-information-block/components/page-links.tsx
Outdated
Show resolved
Hide resolved
Jorrik-Klijnsma-Work
force-pushed
the
feature/COR-1193-markdown-interpreter-links-recogniser
branch
from
December 15, 2022 14:23
05718c0
to
fb69c0e
Compare
Jorrik-Klijnsma-Work
approved these changes
Dec 15, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 2 me
DariaKwork
deleted the
feature/COR-1193-markdown-interpreter-links-recogniser
branch
December 15, 2022 16:11
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
rich-content.tsx
content-teaser.tsx
markdown.tsx
page-links.tsx
Before:
After: